Avoid accidentally enabling unstable features in compilers (take 2) #97277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows rustbuild to control whether crates can use nightly features or not. It also prevents rustbuild from using nightly features itself.
Worked around that by passing |
This statically prevents issues like rust-lang#59264, where tools can only be built with the in-tree compiler and not beta.
|
@bors r+ rollup=iffy |
|
📌 Commit 751ad4a has been approved by |
bors
added
the
S-waiting-on-bors
|
Oops, I pushed 751ad4a right as you reviewed - do you want me to back that out for now? |
|
No, I saw it and it seems good to me. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97043 (Move some tests to more reasonable directories) - rust-lang#97206 (Do leak check after function pointer coercion) - rust-lang#97275 (small change) - rust-lang#97277 (Avoid accidentally enabling unstable features in compilers (take 2)) - rust-lang#97280 (Quote replace target in bootstrap configure) Failed merges: - rust-lang#97214 (Finish bumping stage0) r? `@ghost` `@rustbot` modify labels: rollup
Mark-Simulacrum
added a commit
to pietroalbini/rust
that referenced
this pull request
Jun 27, 2022
This is a beta-only commit to avoid problems introduced by rust-lang#97277; we will want a more targeted patch that specifically re-enables this for a subset of the books (nomicon, unstable book, ...?) and testing via a stable-branch builder for tools, but that isn't worth backporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rustbuild to control whether crates can use nightly features or not.
It also prevents rustbuild from using nightly features itself.
This is #92261, but I fixed the CI error.