Make Lazy*<T> types in rustc_metadata not care about lifetimes until decode

[compiler-errors]

This allows us to remove the 'tcx lifetime from CrateRoot. This is necessary because of #97287, which makes the 'tcx lifetime on Ty invariant instead of covariant, so this hack no longer holds under that PR.

Introduces a trait called ParameterizedOverTcx which has a generic associated type that allows a type to be parameterized over that lifetime. This means we can decode, for example, Lazy<Ty<'static>> into any Ty<'tcx> depending on the TyCtxt<'tcx> we pass into the decode function.

[rust-highfive]

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

[jackh726]

The question: Does this really need to be : 'static? These impls also could be impl<'a> ParameterizedOverTcx for Thing<'a> { type Value<'tcx> = Thing<'tcx>; }, right? Because This is just encoding a higher-kinded lifetime -> type.

[compiler-errors]

Yeah, there's no good reason why we need Self: 'static. That is, it's not there for correctness or anything, necessarily.

I treat it more like a mnemonic, where the lifetime error you'd get is there to discourage you from constructing Lazy<Something<'not_static>>, since there is no guarantee that the 'not_static lifetime is not related to what you get out of lazy.decode(meta).

[jackh726]

One question, but r=me

[compiler-errors]

I guess this could use a perf run too.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit d1a9a95 with merge b4f81f3aa398c1b6b271826fc9a5c488fadc565f...

[bors]

☀️ Try build successful - checks-actions
Build commit: b4f81f3aa398c1b6b271826fc9a5c488fadc565f (b4f81f3aa398c1b6b271826fc9a5c488fadc565f)

[rust-timer]

Queued b4f81f3aa398c1b6b271826fc9a5c488fadc565f with parent 76761db, future comparison URL.

[rust-timer]

Finished benchmarking commit (b4f81f3aa398c1b6b271826fc9a5c488fadc565f): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	1	0	1	0	2
mean2	2.9%	N/A	-1.7%	N/A	0.6%
max	2.9%	N/A	-1.7%	N/A	2.9%

Cycles

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 🎉 relevant improvements found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	0	0	6	0
mean2	N/A	N/A	N/A	-11.8%	N/A
max	N/A	N/A	N/A	-12.9%	N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. number of relevant changes ↩ ↩²

2. the arithmetic mean of the percent change ↩ ↩²

[compiler-errors]

@bors r=jackh726

[bors]

📌 Commit d1a9a95 has been approved by jackh726

[bors]

⌛ Testing commit d1a9a95 with merge 9fadabc...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 9fadabc to master...

[rust-timer]

Finished benchmarking commit (9fadabc): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	0	3	0	0	0
mean2	N/A	2.4%	N/A	N/A	N/A
max	N/A	2.9%	N/A	N/A	N/A

Cycles

Results

• Primary benchmarks: 😿 relevant regression found
• Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	1	7	0	1	1
mean2	2.0%	3.1%	N/A	-2.2%	2.0%
max	2.0%	4.7%	N/A	-2.2%	2.0%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. number of relevant changes ↩ ↩²

2. the arithmetic mean of the percent change ↩ ↩²