Add E0788 for improper #[no_coverage] usage #97495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred in diagnostic error codes |
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
May 28, 2022
nagisa
reviewed
Jun 5, 2022
|
Verifying that I did the UI tests correctly before I push the latest changes from feedback. Resolved the ones where I just used the suggestions verbatim, responded to the ones where I modified them. |
|
@bors r+ Thanks! |
|
📌 Commit 9473e21 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 6, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97312 (Compute lifetimes in scope at diagnostic time) - rust-lang#97495 (Add E0788 for improper #[no_coverage] usage) - rust-lang#97579 (Avoid creating `SmallVec`s in `global_llvm_features`) - rust-lang#97767 (interpret: do not claim UB until we looked more into variadic functions) - rust-lang#97787 (E0432: rust 2018 -> rust 2018 or later in --explain message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, this adds proper checking for the attribute (tracking issue #84605) and throws errors when it's put in obviously-wrong places, like on struct or const definitions. Most of the code is taken directly from the checks for the
#[inline]attribute, since it's very similar.Right now, the code only checks at the function level, but it seems reasonable to allow adding
#[no_coverage]to individual blocks or expressions, so, for now those just throwunused_attributeswarnings. Similarly, since there was a lot of desire to eventually allow recursive definitions as well on modules and impl blocks, these also throwunused_attributesinstead of an error.I'm not sure if anything has to be done since this error is technically for an unstable feature, but since an error for using unstable features will show up anyway, I think it's okay.
This is the first big piece needed for stabilising this attribute, although I personally would like to explore renaming it to
#[coverage(never)]on a separate PR, which I will offer soon. There's a lot of discussion still to be had about that, which is why it will be kept separate.I don't think much is needed besides adding this simple check and a UI test, but let me know if there's something else that should be added to make this happen.