-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new cargo argument in bootstrap for cfg checking #97529
Conversation
@bors r+ rollup=never |
📌 Commit 71f60b43514cc14abbf18c5336b165742008d7d8 has been approved by |
⌛ Testing commit 71f60b43514cc14abbf18c5336b165742008d7d8 with merge 549c79c9bda4ba63fa8e8cb466e9697a98bf739d... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@jyn514 @Mark-Simulacrum (bootstrap team, idk if there things are already setup or not) Would any of you know why when at this stage Context: This PR move some args handling from the |
This comment has been minimized.
This comment has been minimized.
EDIT: Actually I'm not so sure anymore. I'm not even sure |
This comment has been minimized.
This comment has been minimized.
cd6b8d8
to
16b081b
Compare
fdf5967
to
628b50d
Compare
8210be4
to
ff33001
Compare
After some more investigation on CI I'm pretty sure that it's not at all a @rustbot ready |
@bors r+ Seems OK for now. |
📌 Commit ff33001 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3a8e713): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This PR use new cargo argument in bootstrap for doing cfg checking.
Follow-up to #97044 and #97214.
r? @Mark-Simulacrum