Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial stabilization of "nonzero_checked_ops". #97547

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

iago-lito
Copy link
Contributor

@iago-lito iago-lito commented May 30, 2022

Stabilizing checked arithmetics on NonZero types under #![feature(nonzero_checked_ops)] (previously nonzero_ops).

Not closing #84186 as only checked methods are stabilized here.
As per #84186 (comment), the two remaining unchecked methods unchecked_add and unchecked_mul will remain feature-gated under #![feature(nonzero_ops)] until #85122 is stabilized.

Unresolved questions:

@rustbot modify labels: +T-libs-api

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 30, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2022
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2022
@iago-lito
Copy link
Contributor Author

r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs

@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 30, 2022
@rust-log-analyzer

This comment has been minimized.

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch from 9da1c5e to 868eab8 Compare May 30, 2022 12:25
@iago-lito iago-lito changed the title Partial stabilization of "nonzero_unchecked_ops". Partial stabilization of "nonzero_checked_ops". May 30, 2022
@rust-log-analyzer

This comment has been minimized.

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch from 868eab8 to 4fcd8a0 Compare May 30, 2022 12:31
@rust-log-analyzer

This comment has been minimized.

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch 2 times, most recently from c321517 to 6b0f59c Compare May 30, 2022 12:49
@rust-log-analyzer

This comment has been minimized.

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch from 6b0f59c to 04baca9 Compare May 30, 2022 13:05
@rust-log-analyzer

This comment has been minimized.

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch 2 times, most recently from d3c66d3 to dd33983 Compare May 31, 2022 08:32
@yaahc
Copy link
Member

yaahc commented Jun 8, 2022

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jun 8, 2022

Team member @yaahc has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 8, 2022
@yaahc
Copy link
Member

yaahc commented Jun 8, 2022

  • I've taken this opportunity to also implement/stabilize the infra-stable impl Neg for NonZeroI* as part of this PR. Is this the appropriate time to do so?

I think it's fine to collapse them though I'd definitely recommend having separate PRs that way issues on one part of the PR can't block acceptance of the rest of the PR.

I went ahead and marked the stabilized methods as also rustc_const_stable. Is this okay?

I don't think so, though this is another case where if it's something you need I'd recommend handling that as a separate PR. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html#when-theres-const-involved

@iago-lito iago-lito force-pushed the stabilize_non_zero_checked_ops branch from dd33983 to 5823d7b Compare June 9, 2022 07:33
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jun 12, 2022
@rfcbot
Copy link

rfcbot commented Jun 12, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 12, 2022
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 22, 2022
@rfcbot
Copy link

rfcbot commented Jun 22, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@rfcbot rfcbot added the to-announce Announce this issue on triage meeting label Jun 22, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 26, 2022
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 26, 2022
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
@bors bors merged commit 5823d7b into rust-lang:master Jun 26, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 26, 2022
@cuviper cuviper modified the milestones: 1.63.0, 1.64.0 Jul 20, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.