Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alloc: remove repeated word in comment #97578

Merged
merged 1 commit into from
Jun 1, 2022
Merged

alloc: remove repeated word in comment #97578

merged 1 commit into from
Jun 1, 2022

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented May 31, 2022

Linux's checkpatch.pl reports:

#42544: FILE: rust/alloc/vec/mod.rs:2692:
WARNING: Possible repeated word: 'to'
+            // - Elements are :Copy so it's OK to to copy them, without doing

Signed-off-by: Miguel Ojeda ojeda@kernel.org

@ojeda
alloc: remove repeated word in comment
5dae6c1 
Linux's `checkpatch.pl` reports:

```txt
rust-lang#42544: FILE: rust/alloc/vec/mod.rs:2692:
WARNING: Possible repeated word: 'to'
+            // - Elements are :Copy so it's OK to to copy them, without doing
```

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 31, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2022
@JohnTitor
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2022

📌 Commit 5dae6c1 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 31, 2022
@Dylan-DPC
Rollup merge of rust-lang#97578 - ojeda:checkpatch, r=JohnTitor
a97e05c 
alloc: remove repeated word in comment

Linux's `checkpatch.pl` reports:

```txt
rust-lang#42544: FILE: rust/alloc/vec/mod.rs:2692:
WARNING: Possible repeated word: 'to'
+            // - Elements are :Copy so it's OK to to copy them, without doing
```

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@Dylan-DPC Dylan-DPC mentioned this pull request May 31, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 31, 2022
@matthiaskrgr
Rollup merge of rust-lang#97578 - ojeda:checkpatch, r=JohnTitor
8f9e47c 
alloc: remove repeated word in comment

Linux's `checkpatch.pl` reports:

```txt
rust-lang#42544: FILE: rust/alloc/vec/mod.rs:2692:
WARNING: Possible repeated word: 'to'
+            // - Elements are :Copy so it's OK to to copy them, without doing
```

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@matthiaskrgr matthiaskrgr mentioned this pull request May 31, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request May 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2022
@bors
Auto merge of rust-lang#97600 - matthiaskrgr:rollup-yivyeu5, r=matthi…
6f481f8 
…askrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#97316 (Put a bound on collection misbehavior)
 - rust-lang#97578 (alloc: remove repeated word in comment)
 - rust-lang#97593 (:arrow_up: rust-analyzer)
 - rust-lang#97596 (Fixup feature name to be more consistent with others)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0d1e546 into rust-lang:master Jun 1, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 1, 2022
@ojeda ojeda deleted the checkpatch branch June 1, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ojeda @rust-highfive @JohnTitor @bors @thomcc @rustbot