Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate more diagnostics to use the #[derive(SessionDiagnostic)] #97587

Merged
merged 8 commits into from
Jun 2, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented May 31, 2022

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 31, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2022
@pvdrz pvdrz changed the title Migrate maybe_recover_from_bad_qpath_stage_2 diagnostic Migrate more diagnostics to use the #[derive(SessionDiagnostic)] May 31, 2022
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me if you want to fix the nit

compiler/rustc_parse/src/parser/diagnostics.rs Outdated Show resolved Hide resolved
@davidtwco
Copy link
Member

@bors delegate+

@bors
Copy link
Contributor

bors commented Jun 1, 2022

✌️ @pvdrz can now approve this pull request

@pvdrz
Copy link
Contributor Author

pvdrz commented Jun 1, 2022

@bors r+

@oli-obk
Copy link
Contributor

oli-obk commented Jun 1, 2022

@bors r=davidtwco

@bors
Copy link
Contributor

bors commented Jun 1, 2022

📌 Commit 0fa70a8 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 2, 2022
…stage-2, r=davidtwco

Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`

r? `@davidtwco`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#96894 (Apply track_caller to closure on `expect_non_local()`)
 - rust-lang#97023 (Diagnose anonymous lifetimes errors more uniformly between async and regular fns)
 - rust-lang#97397 (Stabilize `box_into_pin`)
 - rust-lang#97587 (Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`)
 - rust-lang#97603 (Arc make_mut doc comment spelling correction.)
 - rust-lang#97635 (Fix file metadata documentation for Windows)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 19dc28c into rust-lang:master Jun 2, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 2, 2022
@pvdrz pvdrz deleted the maybe-recover-from-bad-qpath-stage-2 branch June 2, 2022 17:22
@compiler-errors compiler-errors added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants