Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify universal impl trait lowering #97598

Merged
merged 14 commits into from
Jun 3, 2022
Merged

Simplify universal impl trait lowering #97598

merged 14 commits into from
Jun 3, 2022

Commits on May 31, 2022

  1. Move defs and bounds from Universal to LoweringContext

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    3d6eae8 View commit details
    Browse the repository at this point in the history

  2. Take and restore fields in with_hir_id_owner calls

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    1a71103 View commit details
    Browse the repository at this point in the history

  3. Add itctx: ImplTraitContext arg to add_implicit_generics

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    190b4a7 View commit details
    Browse the repository at this point in the history

  4. Replace calls to lower_generics with calls to add_implicit_generics

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    e080298 View commit details
    Browse the repository at this point in the history

  5. Rename add_implicit_generics to lower_generics

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    d5ab8b2 View commit details
    Browse the repository at this point in the history

  6. Move lower_generics definition to item.rs

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    bd3a097 View commit details
    Browse the repository at this point in the history

  7. derive Copy, Clone, PartialEq, Eq for ImplTraitContext

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    208ffbb View commit details
    Browse the repository at this point in the history

  8. Remove ImplTraitContext::reborrow

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    d327db9 View commit details
    Browse the repository at this point in the history

  9. Inline lower_generics_mut and remove GenericsCtor

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    2ade55d View commit details
    Browse the repository at this point in the history

  10. Fix lower_generics rustdocs

    @spastorino
    spastorino committed May 31, 2022
    Configuration menu
    Copy the full SHA
    15f2b11 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Add debug_assert comment 

    Co-authored-by: Camille Gillot <gillot.camille@gmail.com>
    @spastorino @cjgillot
    spastorino and cjgillot authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b3bc438 View commit details
    Browse the repository at this point in the history

  2. Split extend + inner chain into to extend calls

    @spastorino
    spastorino committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2de2520 View commit details
    Browse the repository at this point in the history

  3. instrument lower_fn_decl

    @spastorino
    spastorino committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    67deaf9 View commit details
    Browse the repository at this point in the history

  4. Always assert that impl_trait_def|bounds are empty at start

    @spastorino
    spastorino committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    15a82d6 View commit details
    Browse the repository at this point in the history