-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #96682. #97636
Revert #96682. #97636
Conversation
The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608.
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
cc @dtolnay |
@bors r+ |
📌 Commit 77e1069 has been approved by |
Revert rust-lang#96682. The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608. r? `@petrochenkov`
Nominating for beta backport as #97608 is a stable-to-beta regression. |
Rollup of 5 pull requests Successful merges: - rust-lang#97420 (Be a little nicer with casts when formatting `fn` pointers) - rust-lang#97450 ([RFC 2011] Basic compiler infrastructure) - rust-lang#97599 (Fix JSON reexport ICE) - rust-lang#97617 (Rustdoc anonymous reexports) - rust-lang#97636 (Revert rust-lang#96682.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
@apiraino: Do I need to do anything to effect the beta backport? |
No, unless there are merge conflicts, but the actual backport will be taken care of by release or someone else. |
Revert rust-lang#96682. The change was "Show invisible delimiters (within comments) when pretty printing". It's useful to show these delimiters, but is a breaking change for some proc macros. Fixes rust-lang#97608. r? ``@petrochenkov``
[beta] Beta backports * Remove the unused-#[doc(hidden)] logic from the unused_attributes lint rust-lang#98336 * debuginfo: Fix NatVis for Rc and Arc with unsized pointees. rust-lang#98137 * Revert "remove num_cpus dependency" in rustc and update cargo rust-lang#97911 * Update LLVM submodule rust-lang#97690 * Revert rust-lang#96682. rust-lang#97636 * don't do Sized and other return type checks on RPIT's real type rust-lang#97431 * Temporarily disable submodule archive downloads. rust-lang#98423
The change was "Show invisible delimiters (within comments) when pretty
printing". It's useful to show these delimiters, but is a breaking
change for some proc macros.
Fixes #97608.
r? @petrochenkov