Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional docs example for replace **all** of str #97921

Merged
merged 1 commit into from
Jun 12, 2022
Merged

additional docs example for replace **all** of str #97921

merged 1 commit into from
Jun 12, 2022

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 9, 2022

No description provided.

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 9, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

1 similar comment
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 12, 2022

📌 Commit 7c861cf has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#97921 - bvanjoi:docs-example-str-replace, r…
5751e72 
…=Dylan-DPC

additional docs example for replace **all** of str
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2022
@bors
Auto merge of rust-lang#98025 - Dylan-DPC:rollup-cwt2hb7, r=Dylan-DPC
53305f1 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97921 (additional docs example for replace **all** of str)
 - rust-lang#97970 (Fix Termination impl panic on closed stderr)
 - rust-lang#97991 (Use safer `strip=symbols`-flag for dylibs on macOS)
 - rust-lang#97992 (Stabilize scoped threads.)
 - rust-lang#98012 (`ValuePairs::PolyTraitRefs` should be called "trait"s in type error diagnostics)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b2172b7 into rust-lang:master Jun 12, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 12, 2022
@bvanjoi bvanjoi deleted the docs-example-str-replace branch April 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@bvanjoi @rust-highfive @Dylan-DPC @bors @joshtriplett @rustbot