Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify #[derive(PartialEq)] on enums #97950

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Clarify #[derive(PartialEq)] on enums #97950

merged 1 commit into from
Jun 13, 2022

Conversation

eggyal
Copy link
Contributor

@eggyal eggyal commented Jun 10, 2022

Fixes #97945

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 10, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

1 similar comment
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 12, 2022

📌 Commit 7bbf914 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#97950 - eggyal:issue-97945, r=Dylan-DPC
84b5909 
Clarify `#[derive(PartialEq)]` on enums

Fixes rust-lang#97945
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Closed
@compiler-errors compiler-errors mentioned this pull request Jun 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2022
@bors
Auto merge of rust-lang#98037 - compiler-errors:rollup-fbvy456, r=com…
c570ab5 
…piler-errors

Rollup of 3 pull requests

Successful merges:

 - rust-lang#97920 (Fix some test annotations)
 - rust-lang#97950 (Clarify `#[derive(PartialEq)]` on enums)
 - rust-lang#98011 (Add documentation for error E0208)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5dccf4e into rust-lang:master Jun 13, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 13, 2022
@eggyal eggyal deleted the issue-97945 branch June 13, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Misleading description of PartialEq derived implementation for enums in docs
6 participants
@eggyal @rust-highfive @Dylan-DPC @bors @Mark-Simulacrum @rustbot