Remove unnecessary to_string and String::new
#98043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
|
Some changes occured in const_evaluatable.rs cc @lcnr Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
davidtwco
approved these changes
Jun 13, 2022
|
r? @davidtwco |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
@bors r+ rollup |
|
📌 Commit fd1290a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: `@davidtwco`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: ``@davidtwco``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 13, 2022
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: ```@davidtwco```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 13, 2022
…g, r=davidtwco Remove unnecessary `to_string` and `String::new` rust-lang@73fa217 changed the type of the `suggestion` argument to `impl ToString`. This patch removes unnecessary `to_string` and `String::new`. cc: ````@davidtwco````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#97709 (Normalize consts' tys when relating with `adt_const_params`) - rust-lang#97875 (Remove the `infer_static_outlives_requirements` feature) - rust-lang#97960 (interpret: unify offset_from check with offset check) - rust-lang#97999 (Make `type_changing_struct_update` no longer an incomplete feature) - rust-lang#98043 (Remove unnecessary `to_string` and `String::new`) - rust-lang#98044 ([issues:97981] del unrelated comment) - rust-lang#98049 (Document an edge case of `str::split_once`) - rust-lang#98050 (Add some more regression tests for rust-lang#67945) - rust-lang#98054 (Fix error message for `download-ci-llvm`) - rust-lang#98057 (Update miri) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
I know this is not the place where the change was made, but why |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 17, 2022
…to-string, r=Dylan-DPC Remove the rest of unnecessary `to_string` I removed most of unnecessary `to_string` in rust-lang#98043. This patch removes the rest of them I missed.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
…to-string, r=Dylan-DPC Remove the rest of unnecessary `to_string` I removed most of unnecessary `to_string` in rust-lang#98043. This patch removes the rest of them I missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
73fa217 changed the type of the
suggestionargument toimpl ToString. This patch removes unnecessaryto_stringandString::new.cc: @davidtwco