Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move finish out of the Encoder trait. #98160

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Move finish out of the Encoder trait. #98160

merged 1 commit into from
Jun 17, 2022

Conversation

nnethercote
Copy link
Contributor

This simplifies things, but requires making CacheEncoder non-generic.

(This was previously merged as commit 4 in #94732 and then was reverted
in #97905 because it caused a perf regression.)

r? @ghost

@nnethercote
Move finish out of the Encoder trait.
bb02cc4 
This simplifies things, but requires making `CacheEncoder` non-generic.

(This was previously merged as commit 4 in rust-lang#94732 and then was reverted
in rust-lang#97905 because it caused a perf regression.)
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 16, 2022
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 16, 2022
@bors
Copy link
Contributor

bors commented Jun 16, 2022

⌛ Trying commit bb02cc4 with merge 0cd7b450822dac8f46a45cfb4444f067b437e6e3...

@bors
Copy link
Contributor

bors commented Jun 16, 2022

☀️ Try build successful - checks-actions
Build commit: 0cd7b450822dac8f46a45cfb4444f067b437e6e3 (0cd7b450822dac8f46a45cfb4444f067b437e6e3)

@rust-timer
Copy link
Collaborator

Queued 0cd7b450822dac8f46a45cfb4444f067b437e6e3 with parent 1b9daa6, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0cd7b450822dac8f46a45cfb4444f067b437e6e3): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.7% -4.7% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -3.2% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.2% -3.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 16, 2022
@nnethercote
Copy link
Contributor Author

Well that's weird. Last time this commit was a clear regression, but now it's perf-neutral?

r? @bjorn3

@bjorn3
Copy link
Member

bjorn3 commented Jun 16, 2022

Weird. Let's try landing it one more time and if it turns out to be a regression revert it.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jun 16, 2022

📌 Commit bb02cc4 has been approved by bjorn3

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2022
@bors
Copy link
Contributor

bors commented Jun 17, 2022

⌛ Testing commit bb02cc4 with merge 0423e06...

@bors
Copy link
Contributor

bors commented Jun 17, 2022

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 0423e06 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2022
@bors bors merged commit 0423e06 into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@bors bors mentioned this pull request Jun 17, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0423e06): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.4% 2.4% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@nnethercote nnethercote deleted the mv-finish-out-of-Encoder branch June 20, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rust-timer @bors @bjorn3 @rustbot