-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fs::get_path
for FreeBSD.
#98211
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
(rust-highfive has picked a reviewer for you, use r? to override) |
302baa3
to
047a842
Compare
Ping from triage: FYI: when a PR is ready for review, send a message containing |
@rustbot ready |
Hm, so looking at how large that struct is, I'm now wondering if we should be placing it on the heap -- it seems like a kilobyte+ is a pretty big thing to stick onto the stack. I think our stacks are typically a few megabytes, and this function can't see any recursion, but the heap allocation is also likely to be pretty cheap when we're making a syscall anyway. It looks like on other platforms the get_path helpers all use a heap allocation, so adding one here won't be too odd hopefully. |
047a842
to
32d80f4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
32d80f4
to
5803492
Compare
@rustbot ready |
@bors r+ |
…imulacrum Implement `fs::get_path` for FreeBSD. Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.
Failed in rollup: #99726 (comment) |
oh I forgot it was only amd64 arch... |
Using `F_KINFO` fcntl flag, the kf_structsize field needs to be set beforehand for that effect.
5803492
to
e39b44a
Compare
@bors r+ |
Rollup of 7 pull requests Successful merges: - rust-lang#98211 (Implement `fs::get_path` for FreeBSD.) - rust-lang#99353 (Slightly improve mismatched GAT where clause error) - rust-lang#99593 (Suggest removing the tuple struct field for the unwrapped value) - rust-lang#99615 (Remove some explicit `self.infcx` for `FnCtxt`, which already derefs into `InferCtxt`) - rust-lang#99711 (Remove reachable coverage without counters) - rust-lang#99718 (Avoid `&str`/`Symbol` to `String` conversions) - rust-lang#99720 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 7 pull requests Successful merges: - rust-lang#98211 (Implement `fs::get_path` for FreeBSD.) - rust-lang#99353 (Slightly improve mismatched GAT where clause error) - rust-lang#99593 (Suggest removing the tuple struct field for the unwrapped value) - rust-lang#99615 (Remove some explicit `self.infcx` for `FnCtxt`, which already derefs into `InferCtxt`) - rust-lang#99711 (Remove reachable coverage without counters) - rust-lang#99718 (Avoid `&str`/`Symbol` to `String` conversions) - rust-lang#99720 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Using
F_KINFO
fcntl flag, the kf_structsize fieldneeds to be set beforehand for that effect.