Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #98347

Closed
wants to merge 19 commits into from
Closed

Commits on Jun 8, 2022

  1. Configuration menu
    Copy the full SHA
    c7b6e1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0667b00 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Configuration menu
    Copy the full SHA
    3f12fa7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dda980d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    810254b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f4db07e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    987c731 View commit details
    Browse the repository at this point in the history
  6. Support setting file accessed/modified timestamps

    Add `struct FileTimes` to contain the relevant file timestamps, since
    most platforms require setting all of them at once. (This also allows
    for future platform-specific extensions such as setting creation time.)
    
    Add `File::set_file_time` to set the timestamps for a `File`.
    
    Implement the `sys` backends for UNIX, macOS (which needs to fall back
    to `futimes` before macOS 10.13 because it lacks `futimens`), Windows,
    and WASI.
    joshtriplett committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    eb6141e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    585767d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    beb2f36 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Configuration menu
    Copy the full SHA
    e900a35 View commit details
    Browse the repository at this point in the history
  2. Add a full regression test for rust-lang#73727

    Signed-off-by: Yuki Okushi <jtitor@2k36.org>
    JohnTitor committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    31476e7 View commit details
    Browse the repository at this point in the history
  3. This comment is out dated and misleading

    Arms are about TAIT and RPIT, as the variants clearly show.
    spastorino committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    5ed1495 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#91264 - GuillaumeGomez:macro-jump-to-def, r…

    …=jsha
    
    Add macro support in jump to definition feature
    
    Fixes rust-lang#91174.
    
    To do so, I check if the span comes from an expansion, and if so, I infer the original macro `DefId` or `Span` depending if it's a defined in the current crate or not.
    
    There is one limitation due to macro expansion though:
    
    ```rust
    macro_rules! yolo { () => {}}
    
    fn foo() {
        yolo!();
    }
    ```
    
    In `foo`, `yolo!` won't be linked because after expansion, it is replaced by nothing (which seems logical). So I can't get an item from the `Visitor` from which I could tell if its `Span` comes from an expansion.
    
    I added a test for this specific limitation alongside others.
    
    Demo: https://rustdoc.crud.net/imperio/macro-jump-to-def/src/foo/check-source-code-urls-to-def-std.rs.html
    
    As for the empty macro issue that cannot create a jump to definition, you can see it [here](https://rustdoc.crud.net/imperio/macro-jump-to-def/src/foo/check-source-code-urls-to-def-std.rs.html#35).
    
    r? ``@jyn514``
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    d502e83 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#97867 - lcnr:lub-binder, r=oli-obk

    lub: don't bail out due to empty binders
    
    allows for the following to compile. The equivalent code using `struct Wrapper<'upper>(fn(&'upper ());` already compiles on stable.
    ```rust
    let _: fn(&'upper ()) = match v {
        true => lt_in_fn::<'a>(),
        false => lt_in_fn::<'b>(),
    };
    ```
    see https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=7034a677190110941223cafac6632f70 for a complete example
    
    r? ``@rust-lang/types``
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    a6de3f6 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#98184 - compiler-errors:elided-lifetime-in-…

    …impl-nll, r=cjgillot
    
    Give name if anonymous region appears in impl signature
    
    Fixes rust-lang#98170
    
    We probably should remove the two unwraps in [`report_general_error`](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_borrowck/diagnostics/region_errors.rs.html#683-685), but I have no idea what to provide if those regions are missing, so I've kept those in. Let me know if I should try harder to remove those.
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    b5a2a80 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#98246 - joshtriplett:times, r=m-ou-se

    Support setting file accessed/modified timestamps
    
    Add `struct FileTimes` to contain the relevant file timestamps, since
    most platforms require setting all of them at once. (This also allows
    for future platform-specific extensions such as setting creation time.)
    
    Add `File::set_file_time` to set the timestamps for a `File`.
    
    Implement the `sys` backends for UNIX, macOS (which needs to fall back
    to `futimes` before macOS 10.13 because it lacks `futimens`), Windows,
    and WASI.
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    223d7f8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#98334 - JohnTitor:issue-73727, r=compiler-e…

    …rrors
    
    Add a full regression test for rust-lang#73727
    
    Closes rust-lang#73727
    
    This also moves a test to the `issues` directory as it's also tested on the adt_const_params feature.
    
    r? ``@compiler-errors``
    
    Signed-off-by: Yuki Okushi <jtitor@2k36.org>
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    2b1ce20 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#98344 - spastorino:remove-misleading-commen…

    …t, r=oli-obk
    
    This comment is out dated and misleading, the arm is about TAITs
    
    r? ``@oli-obk``
    
    ``@oli-obk`` unsure if you want to add a different comment of some sort.
    
    ``@bors`` rollup=always
    Dylan-DPC committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9bf095d View commit details
    Browse the repository at this point in the history