Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #98518

Merged
merged 1 commit into from
Jun 26, 2022
Merged

update Miri #98518

merged 1 commit into from
Jun 26, 2022

Conversation

RalfJung
Copy link
Member

Fixes #98493 (this is a flaky test, that's why the toolstate already says Miri is fixed)
r? @ghost Cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit 61a986a has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 26, 2022
@bors
Copy link
Contributor

bors commented Jun 26, 2022

⌛ Testing commit 61a986a with merge 7125846...

@bors
Copy link
Contributor

bors commented Jun 26, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 7125846 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 26, 2022
@bors bors merged commit 7125846 into rust-lang:master Jun 26, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 26, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #98518!

Tested on commit 7125846.
Direct link to PR: #98518

🎉 miri on linux: test-fail → test-pass (cc @RalfJung @eddyb @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 26, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#98518!
c1d101c 
Tested on commit rust-lang/rust@7125846.
Direct link to PR: <rust-lang/rust#98518>

🎉 miri on linux: test-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
This was referenced Jun 26, 2022
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7125846): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.5% 1.5% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.5% 2.7% 3
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 3.2% 3.3% 3
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -3.2% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 1.6% 3.3% 4

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@RalfJung RalfJung deleted the miri branch June 28, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#98486
5 participants
@RalfJung @bors @rust-highfive @rust-timer @rustbot