Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in SAFETY comment #98561

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix spelling in SAFETY comment #98561

merged 1 commit into from
Jun 27, 2022

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Jun 27, 2022

"can not" should be "cannot", and add punctuation.

@Wilfred
Fix spelling in SAFETY comment
1c1ae78 
"can not" should be "cannot", and add punctuation.
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 27, 2022
@rust-highfive
Copy link
Collaborator

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2022
fee1-dead
fee1-dead approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@fee1-dead fee1-dead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 27, 2022

📌 Commit 1c1ae78 has been approved by fee1-dead

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2022
@fee1-dead fee1-dead assigned fee1-dead and unassigned m-ou-se Jun 27, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 27, 2022
@bors
Auto merge of rust-lang#98566 - matthiaskrgr:rollup-43etyls, r=matthi…
8e52fa8 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97389 (Improve memory ordering diagnostics)
 - rust-lang#97780 (Check ADT field is well-formed before checking it is sized)
 - rust-lang#98530 (compiletest: add issue number param to `known-bug`)
 - rust-lang#98556 (Fix builds on Windows (closes rust-lang#98546))
 - rust-lang#98561 (Fix spelling in SAFETY comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54b81dd into rust-lang:master Jun 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead approved these changes

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Wilfred @rust-highfive @fee1-dead @bors @m-ou-se @rustbot