more need_type_info improvements
#98761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Jul 1, 2022
Comment on lines
2011
to
2015
| let impl_candidates = self | ||
| .find_similar_impl_candidates(trait_ref) | ||
| .into_iter() | ||
| .map(|candidate| candidate.trait_ref) | ||
| .collect(); |
There was a problem hiding this comment.
Could we make a note to see if we can check whether this snippet is useful to modify err in some way? I fear we must have had a suggestion regression at some point.
estebank
reviewed
Jul 1, 2022
Comment on lines
+26
to
+29
| help: try using a fully qualified path to specify the expected types | ||
| | | ||
| LL | <Vec<T> as Foo>::foo(&x); | ||
| | ++++++++++++++++++++++ ~ |
There was a problem hiding this comment.
This should have been <Vec<isize> as Foo>::foo(&x), but that'd be outside of scope for this PR.
|
@bors r+ |
|
📌 Commit 458718170b4252f85b2e795d6968d0b0faa6120e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 1, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#97249 (`<details>`/`<summary>` UI fixes) - rust-lang#98418 (Allow macOS to build LLVM as shared library) - rust-lang#98460 (Use CSS variables to handle theming) - rust-lang#98497 (Improve some inference diagnostics) - rust-lang#98708 (rustdoc: fix 98690 Panic if invalid path for -Z persist-doctests) Failed merges: - rust-lang#98761 (more `need_type_info` improvements) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #98781) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors r=estebank |
|
📌 Commit f475e88 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
more `need_type_info` improvements this now deals with macros in suggestions and the source cost computation does what I want for `channel` 🎉 r? `@estebank`
This was referenced Jul 4, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#97300 (Implement `FusedIterator` for `std::net::[Into]Incoming`) - rust-lang#98761 (more `need_type_info` improvements) - rust-lang#98811 (Interpret: AllocRange Debug impl, and use it more consistently) - rust-lang#98847 (fix interpreter validity check on Box) - rust-lang#98854 (clean up the borrowing in rustc_hir_pretty) - rust-lang#98873 (Suggest `#[derive(Default)]` to enums with `#[default]`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this now deals with macros in suggestions and the source cost computation does what I want for
channel🎉r? @estebank