Rollup of 6 pull requests #98963
Merged
Rollup of 6 pull requests #98963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running steps multiple times defeats the whole point of rust-lang#96501, since lint messages will be duplicated.
This makes it much simpler to add new interned types, rather than having to add 4+ impl blocks for each type.
- Add `Interned<Vec<String>>` and use it for tail args - Refactor `cache.rs` not to need a separate impl for each internable type
When cross compiling on macOS with `llvm.link-shared` enabled, the symlink creation will fail after compiling LLVM for the target architecture, because it will attempt to create the symlink in the host LLVM directory, which was already created when being built. This commit changes the symlink path to the actual LLVM output.
Cosmetic improvements. Adds a paragraph break, and ellipses to signify arbitrary size of a flat set.
…imulacrum bootstrap: Allow building individual crates This aims to be as unintrusive as possible, but did still require adding a new `tail_args` field to all `Rustc` and `Std` steps. New library and compiler crates are added to the sysroot as they are built, since it's useful to have e.g. just alloc and not std. Fixes rust-lang#44293.
Fix repr(align) enum handling `enum`, for better or worse, supports `repr(align)`. That has already caused a bug in rust-lang#92464, which was "fixed" in rust-lang#92932, but it turns out that that fix is wrong and caused rust-lang#96185. So this reverts rust-lang#92932 (which fixes rust-lang#96185), and attempts another strategy for fixing rust-lang#92464: special-case enums when doing a cast, re-using the code to load the discriminant rather than assuming that the enum has scalar layout. This works fine for the interpreter. However, rust-lang#92464 contained another testcase that was previously not in the test suite -- and after adding it, it ICEs again. This is not surprising; codegen needs the same patch that I did in the interpreter. Probably this has to happen [around here](https://github.com/rust-lang/rust/blob/d32ce37a171663048a4c4a536803434e40f52bd6/compiler/rustc_codegen_ssa/src/mir/rvalue.rs#L276). Unfortunately I don't know how to do that -- the interpreter can load a discriminant from an operand, but codegen can only do that from a place. `@oli-obk` `@eddyb` `@bjorn3` any idea?
…use, r=notriddle Fix whitespace handling after where clause Fixes rust-lang#97733. You can see the result [here](https://rustdoc.crud.net/imperio/whitespace-where-clause/doc/foo/index.html). r? `@jsha`
Proper macOS libLLVM symlink when cross compiling Follow up of rust-lang#98418 When cross compiling on macOS with `llvm.link-shared` enabled, the symlink creation will fail after compiling LLVM for the target architecture, because it will attempt to create the symlink in the host LLVM directory, which was already created when being built. This commit changes the symlink path to the actual LLVM output. r? `@jyn514`
Edit `rustc_mir_dataflow::framework::lattice::FlatSet` docs Cosmetic improvements. Adds a paragraph break, and ellipses to signify arbitrary size of a flat set.
Update books ## nomicon 2 commits in 3a43983b76174342b7dbd3e12ea2c49f762e52be..70db9e4189f64d1d8e2451b1046111fb356b6dc2 2022-05-30 17:01:30 +0900 to 2022-06-27 20:47:21 +0900 - should be `size_of` instead of `align_of` (rust-lang/nomicon#371) - Fix wording on the aliasing section (rust-lang/nomicon#366) ## book 20 commits in efbafdba3618487fbc9305318fcab9775132ac15..cf2653a5ca553cbbb4a17f1a7db1947820f6a775 2022-06-19 21:06:50 -0400 to 2022-07-05 12:07:58 -0400 - Frontmatter - Update to Rust 1.62 - Extract where clause example so it'll get rustfmtted in the future - Merge remote-tracking branch 'origin/pr/3238' into extract-where-clause-example - Fix line wrapping of lib placement fix - Fix grammar, spelling, and line wrapping of description of appendices - Merge remote-tracking branch 'origin/pr/3244' into binlib - Clarify *type* parameter names - Fix listing 8-21. Fixes rust-lang/book#3251 - Propagate tech review changes for ch13 - Responses to tech review of chapter 13 - Tech review comments on chapter 13 - Fix double the - Propagate tech review chapter 1 changes to src - Address tech review comments for chapter 1 - Tech review comments for chapter 1 - Fix grammar - Fix grammar - Edits to edits to the introduction - Comments from nostarch on the introduction ## rust-by-example 8 commits in 1095df2a5850f2d345fad43a30633133365875ba..83724ca387a2a1cd3e8d848f62820020760e358b 2022-06-18 21:47:12 -0300 to 2022-07-05 10:38:07 -0300 - changing names of params (rust-lang/rust-by-example#1567) - Update incorrect print output in std/box.md (rust-lang/rust-by-example#1564) - minor typo (rust-lang/rust-by-example#1563) - fix: Fibonacci sequence starts from zero (rust-lang/rust-by-example#1562) - add Vietnamese version on README.md (rust-lang/rust-by-example#1561) - Update variadics.md (rust-lang/rust-by-example#1559) - Change fold to sum in fn hof.md (rust-lang/rust-by-example#1560) - Small typo, fixed compileable -> compilable (rust-lang/rust-by-example#1556) ## rustc-dev-guide 8 commits in 048d925f0a955aac601c4160c0e7f05771bcf63b..eb83839e903a0a8f1406f7e941886273f189b26b 2022-06-21 22:25:34 +0900 to 2022-07-03 15:17:39 +0900 - Suggest a separate build directory for rust-analyzer (rust-lang/rustc-dev-guide#1378) - Change the old filename, "src/stage0.txt" to "src/stage0.json" (rust-lang/rustc-dev-guide#1383) - Add the config needed to get rust-analyzer working on src/bootstrap (rust-lang/rustc-dev-guide#1381) - Fix path to hir_id_validator.rs - leave formatOnSave to the user (rust-lang/rustc-dev-guide#1380) - diagnostics: structs with new slug syntax (rust-lang/rustc-dev-guide#1377) - Few readability fixes - humorust: Forbid pineapple on pizza (rust-lang/rustc-dev-guide#1374) ## embedded-book 1 commits in e17dcef5e96346ee3d7fa56820ddc7e5c39636bc..766979590da8100998f0d662499d4a901d8d1640 2022-06-19 10:28:00 +0000 to 2022-07-04 09:13:58 +0000 - "linker `link.exe` not found" fix (rust-embedded/book#321)
rustbot
added
T-compiler
|
@bors r+ p=6 rollup=never |
|
📌 Commit 0eded16 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f342bea): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
|
Yes, since #95503 you have to use |
|
Hmm, probably should have updated the changelog in that PR, I'll try and do that today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_mir_dataflow::framework::lattice::FlatSetdocs #98944 (Editrustc_mir_dataflow::framework::lattice::FlatSetdocs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup