Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run stage 0 std tests in CI #99040

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Run stage 0 std tests in CI #99040

merged 2 commits into from
Jul 17, 2022

Conversation

gimbling-away
Copy link
Contributor

@gimbling-away gimbling-away commented Jul 8, 2022 •
edited by jyn514
Loading

Fixes #95996

@rust-highfive
Copy link
Collaborator

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2022
@gimbling-away
Copy link
Contributor Author

Fixes #95996

@gimbling-away gimbling-away mentioned this pull request Jul 8, 2022
Closed
@jyn514 jyn514 changed the title Run std tests in CI Run stage 0 std tests in CI Jul 8, 2022
@jyn514 jyn514 added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 8, 2022
@gimbling-away @jyn514
Update src/ci/docker/host-x86_64/mingw-check/Dockerfile
f56fe9b 
Co-authored-by: Joshua Nelson <github@jyn.dev>
@pietroalbini
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 8, 2022

📌 Commit f56fe9b has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2022
@jyn514 jyn514 mentioned this pull request Jul 11, 2022
Closed
@Dylan-DPC
Copy link
Member

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jul 17, 2022

⌛ Testing commit f56fe9b with merge 967a9c9...

@bors
Copy link
Contributor

bors commented Jul 17, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 967a9c9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2022
@bors bors merged commit 967a9c9 into rust-lang:master Jul 17, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 17, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (967a9c9): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.3% 3.0% 6
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 5.8% 5.8% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.0% -1.0% 1
All 😿🎉 (primary) 5.8% 5.8% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.2% -2.2% 2
Improvements 🎉
(secondary)		 -2.5% -3.3% 8
All 😿🎉 (primary) -2.2% -2.2% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added the perf-regression Performance regression. label Jul 17, 2022
@rylev
Copy link
Member

rylev commented Jul 19, 2022

The regression is just noise correction from the previous run.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Run test --stage 0 library/std in CI
9 participants
@gimbling-away @rust-highfive @pietroalbini @bors @Dylan-DPC @rust-timer @rylev @jyn514 @rustbot