Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc #99452

Merged
merged 1 commit into from
Jul 20, 2022
Merged

int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc #99452

merged 1 commit into from
Jul 20, 2022

Conversation

Stargateur
Copy link
Contributor

typo in doc here "returns" => "takes"

@rustbot label +T-rustdoc

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 19, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2022
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 19, 2022
@JohnTitor
Copy link
Member

Good catch, thanks!
r? @JohnTitor @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 19, 2022

📌 Commit 94f633b has been approved by JohnTitor

It is now in the queue for this repository.

@rust-highfive rust-highfive assigned JohnTitor and unassigned kennytm Jul 19, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2022
@bors
Auto merge of rust-lang#99493 - Dylan-DPC:rollup-lli4gcx, r=Dylan-DPC
748cb1f 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98784 (Suggest returning local on "expected `ty`, found `()`" due to expr-less block)
 - rust-lang#98916 (Windows: Use `FindFirstFileW` for getting the metadata of locked system files)
 - rust-lang#99433 (Erase regions before comparing signatures of foreign fns.)
 - rust-lang#99452 (int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc)
 - rust-lang#99481 (Add regression test for rust-lang#71547)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit feebc5f into rust-lang:master Jul 20, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 20, 2022
@Stargateur Stargateur deleted the fix/typo branch July 20, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Stargateur @rustbot @rust-highfive @JohnTitor @bors @kennytm