Display raw pointer as {mut,const} T instead of -ptr in errors #99517

Noratrieb · 2022-07-20T16:36:22Z

The *-ptr is rather confusing, and we have the full information for properly displaying the information.

rust-highfive · 2022-07-20T16:36:26Z

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

wesleywiser · 2022-07-21T15:08:59Z

This seems reasonable to me, but I'm unsure if there's an existing convention here that we are trying to move towards.

@estebank @compiler-errors how do you feel about saying raw pointer in error messages instead of *-ptr?

estebank · 2022-07-21T20:21:13Z

I'm ok with calling them by name, but it'd be lovely if we did the same thing we do for references and mention what type they are a pointer for.

Noratrieb · 2022-07-27T11:43:59Z

That's a great idea, especially since it's trivial to implement. So I did that.

Noratrieb · 2022-08-14T19:02:19Z

@estebank @compiler-errors is this good now?

compiler-errors

Looks good, r=me with one nit

compiler/rustc_middle/src/ty/error.rs

compiler-errors · 2022-08-14T19:06:00Z

r? @compiler-errors
@bors delegate+

bors · 2022-08-14T19:06:03Z

✌️ @Nilstrieb can now approve this pull request

compiler/rustc_middle/src/ty/error.rs

compiler-errors · 2022-08-14T20:16:24Z

compiler/rustc_middle/src/ty/error.rs

+                let tymut_string = match tymut.mutbl {
+                    hir::Mutability::Mut => tymut.to_string(),
+                    hir::Mutability::Not => format!("const {}", tymut.ty),
+                };
+                if tymut_string != "_" && tymut.ty.is_simple_text() {
+                    format!("`*{}`", tymut_string).into()


I think this works

Suggested change

let tymut_string = match tymut.mutbl {

hir::Mutability::Mut => tymut.to_string(),

hir::Mutability::Not => format!("const {}", tymut.ty),

};

if tymut_string != "_" && tymut.ty.is_simple_text() {

format!("`*{}`", tymut_string).into()

if tymut.ty.is_simple_text() {

self.to_string()

I also wonder if we should change the code below for ty::Ref to match

I could try it out tomorrow if you want to

Please do, thanks!

It would be pretty bad, the length check is really needed here:

- | expected `&T`, found type parameter `T` + | expected reference, found type parameter `T`

- | ---------- ^ expected `&dyn Trait`, found struct `Box` + | ---------- ^ expected reference, found struct `Box`

I'm not sure if I understand how removing the length check causes &T to be rendered as "reference"

oh, it's because ty is not considered simple_text... ugh

Could we modify the logic to make a ref dyn Trait be considered "simple"?

Edit: all it would take is adding a match arm in is_simple_ty to handle Dynamic in the same way we handle Adt in is_simple_text.

it's more complex than that, since a Dynamic is a List<Binder<ExistentialPredicate>>

I also think that having the length check is nicer than the is_simple_ty check, since this exists to avoid bloating the output, so a length check will always be more accurate than a type complexity check.

Length check is fine then. As a final follow-up, is it possible to make the & and * printing logic as similar as possible?

raw pointer is a little too short for the length check imo. I'll use const raw pointer, even though that is not actually used, but since the type will have a const prefix for the pointer, that seems fair

compiler-errors · 2022-08-20T19:28:24Z

r=me with the last comment or not

@bors delegate+

bors · 2022-08-20T19:28:26Z

✌️ @Nilstrieb can now approve this pull request

The `*-ptr` is rather confusing, and we have the full information for properly displaying the information.

compiler-errors · 2022-08-30T06:27:14Z

Thanks nils @bors r+

bors · 2022-08-30T06:27:16Z

📌 Commit 5021dcd has been approved by compiler-errors

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#99517 (Display raw pointer as *{mut,const} T instead of *-ptr in errors) - rust-lang#99928 (Do not leak type variables from opaque type relation) - rust-lang#100473 (Attempt to normalize `FnDef` signature in `InferCtxt::cmp`) - rust-lang#100653 (Move the cast_float_to_int fallback code to GCC) - rust-lang#100941 (Point at the string inside literal and mention if we need string inte…) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned wesleywiser Jul 20, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 20, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022

wesleywiser approved these changes Jul 21, 2022

View reviewed changes

Noratrieb force-pushed the display-raw-ptr branch from a40d796 to 9e539d3 Compare July 27, 2022 11:42

Noratrieb changed the title ~~Display raw pointer as raw pointer instead of *-ptr in errors~~ Display raw pointer as *{mut,const} T instead of *-ptr in errors Jul 27, 2022

compiler-errors approved these changes Aug 14, 2022

View reviewed changes

compiler/rustc_middle/src/ty/error.rs Show resolved Hide resolved

rust-highfive assigned compiler-errors Aug 14, 2022

rust-highfive unassigned wesleywiser Aug 14, 2022

Noratrieb force-pushed the display-raw-ptr branch from 9e539d3 to 860ba27 Compare August 14, 2022 19:14

compiler-errors reviewed Aug 14, 2022

View reviewed changes

compiler/rustc_middle/src/ty/error.rs Outdated Show resolved Hide resolved

Noratrieb force-pushed the display-raw-ptr branch from 860ba27 to 2806cf4 Compare August 14, 2022 20:11

compiler-errors reviewed Aug 14, 2022

View reviewed changes

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2022

Noratrieb force-pushed the display-raw-ptr branch from 2806cf4 to 4e8e49e Compare August 29, 2022 18:07

Display raw pointer as *{mut,const} T instead of *-ptr in errors

5021dcd

The `*-ptr` is rather confusing, and we have the full information for properly displaying the information.

Noratrieb force-pushed the display-raw-ptr branch from 4e8e49e to 5021dcd Compare August 29, 2022 18:40

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 30, 2022

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 30, 2022

Dylan-DPC mentioned this pull request Aug 30, 2022

Rollup of 5 pull requests #101195

Merged

bors merged commit 548ed40 into rust-lang:master Aug 30, 2022

rustbot added this to the 1.65.0 milestone Aug 30, 2022

Noratrieb deleted the display-raw-ptr branch August 30, 2022 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display raw pointer as {mut,const} T instead of -ptr in errors #99517

Display raw pointer as {mut,const} T instead of -ptr in errors #99517

Noratrieb commented Jul 20, 2022 •

edited

Loading

rust-highfive commented Jul 20, 2022

wesleywiser commented Jul 21, 2022

estebank commented Jul 21, 2022

Noratrieb commented Jul 27, 2022

Noratrieb commented Aug 14, 2022

compiler-errors left a comment

compiler-errors commented Aug 14, 2022

bors commented Aug 14, 2022

compiler-errors Aug 14, 2022

Noratrieb Aug 14, 2022

compiler-errors Aug 14, 2022

Noratrieb Aug 16, 2022 •

edited

Loading

compiler-errors Aug 16, 2022

compiler-errors Aug 16, 2022

estebank Aug 17, 2022 •

edited

Loading

Noratrieb Aug 20, 2022

compiler-errors Aug 20, 2022

Noratrieb Aug 20, 2022

compiler-errors commented Aug 20, 2022

bors commented Aug 20, 2022

compiler-errors commented Aug 30, 2022

bors commented Aug 30, 2022

Display raw pointer as *{mut,const} T instead of *-ptr in errors #99517

Display raw pointer as *{mut,const} T instead of *-ptr in errors #99517

Conversation

Noratrieb commented Jul 20, 2022 • edited Loading

rust-highfive commented Jul 20, 2022

wesleywiser commented Jul 21, 2022

estebank commented Jul 21, 2022

Noratrieb commented Jul 27, 2022

Noratrieb commented Aug 14, 2022

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors commented Aug 14, 2022

bors commented Aug 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Noratrieb Aug 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

estebank Aug 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

compiler-errors commented Aug 20, 2022

bors commented Aug 20, 2022

compiler-errors commented Aug 30, 2022

bors commented Aug 30, 2022

Display raw pointer as {mut,const} T instead of -ptr in errors #99517

Display raw pointer as {mut,const} T instead of -ptr in errors #99517

Noratrieb commented Jul 20, 2022 •

edited

Loading

Noratrieb Aug 16, 2022 •

edited

Loading

estebank Aug 17, 2022 •

edited

Loading