Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - remove unnecessary mut that gives a warning #99657

Merged
merged 1 commit into from Jul 24, 2022
Merged

Docs - remove unnecessary mut that gives a warning #99657

merged 1 commit into from Jul 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2022 •
edited by ghost
Loading

Fixes #99654.

A trivial linting fix for a Stdio example.

@rustbot label +T-lib

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 24, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2022
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit 4855392 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022
@RalfJung RalfJung mentioned this pull request Jul 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2022
@bors
Auto merge of rust-lang#99687 - RalfJung:rollup-bojacrc, r=RalfJung
7fe022f 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#99644 (remove some provenance-related machine hooks that Miri no longer needs)
 - rust-lang#99657 (Docs - remove unnecessary `mut` that gives a warning)
 - rust-lang#99672 (Remove Clean trait implementation for more items)
 - rust-lang#99678 (Update doc comments that refer to config parameter)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 51b3d51 into rust-lang:master Jul 24, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 24, 2022
@ghost ghost deleted the patch-1 branch July 24, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

First code example regarding stdin emits a warning
5 participants
@rust-highfive @rustbot @Dylan-DPC @bors @m-ou-se