Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable submodule archive downloads. #99772

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Re-enable submodule archive downloads. #99772

merged 1 commit into from
Aug 4, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 26, 2022

This is effectively a revert of #98423 (though it keeps the --depth 1 flag since that is still helpful).

GitHub has indicated that they have been working on the original issue, and my testing shows that the llvm-project archive download now succeeds 100% of the time.

This should save about a minute on every job.

@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 26, 2022
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jul 26, 2022

📌 Commit cefaa9f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2022
@bors
Copy link
Contributor

bors commented Aug 1, 2022

⌛ Testing commit cefaa9f with merge 87a359101932a3088f434ebfa71150aeea8c06f1...

@bors
Copy link
Contributor

bors commented Aug 1, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2022
@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
---- [ui] src/test/ui/rfcs/rfc-1014-2.rs stdout ----

error: test run failed!
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-1014-2/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-1014-2/a", waiting for result
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9
------------------------------------------

@ehuss
Copy link
Contributor Author

ehuss commented Aug 3, 2022

@bors retry

#97669

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 4, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2022
@bors
Auto merge of rust-lang#100151 - matthiaskrgr:rollup-irqwvj2, r=matth…
f6f9d5e 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#98796 (Do not exclusively suggest `;` when `,` is also a choice)
 - rust-lang#99772 (Re-enable submodule archive downloads.)
 - rust-lang#100058 (Suggest a positional formatting argument instead of a captured argument)
 - rust-lang#100093 (Enable unused_parens for match arms)
 - rust-lang#100095 (More EarlyBinder cleanups)
 - rust-lang#100138 (Remove more Clean trait implementations)
 - rust-lang#100148 (RustWrapper: update for TypedPointerType in LLVM)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 87dd56f into rust-lang:master Aug 4, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @rust-log-analyzer @kennytm @rustbot