Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] add -Z split_bundled_libs #99773

Closed
wants to merge 14 commits into from
Closed

[WIP] add -Z split_bundled_libs #99773

wants to merge 14 commits into from

Conversation

Bryanskiy
Copy link
Contributor

related to #99429

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 26, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Jul 27, 2022
View reviewed changes
compiler/rustc_session/src/options.rs Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
compiler/rustc_codegen_ssa/src/back/link.rs Outdated Show resolved Hide resolved
src/test/run-make/native-link-modifier-bundle-split/Makefile Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2022
@Bryanskiy
Copy link
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 28, 2022
@petrochenkov
Copy link
Contributor

We need feedback from Cargo team on this approach (keeping native libraries bundled into a rlib in separate files next to the rlib).
I made a Zulip thread about this a few days ago - https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Bundled.20static.20libraries.20as.20separate.20files.
We are ready to do the implementation work in cargo if necessary.

@petrochenkov petrochenkov added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2022
@bors
Copy link
Contributor

bors commented Jul 29, 2022

☔ The latest upstream changes (presumably #99467) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov petrochenkov mentioned this pull request Aug 2, 2022
Closed
@petrochenkov
Copy link
Contributor

Closing in favor of #100101.
We need to at least land and stabilize that PR before trying to make a next step like this.

@workingjubilee workingjubilee added the A-cli Area: Command line interface to the compiler. label Mar 5, 2023
@Bryanskiy Bryanskiy deleted the bundle-whole-archive branch May 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-cli Area: Command line interface to the compiler. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Bryanskiy @rust-highfive @petrochenkov @rust-log-analyzer @bors @estebank @workingjubilee @rustbot