Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triagebot.yml: CC Enselic when rustdoc-json-types changes #99921

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jul 29, 2022

Being the maintainer of cargo-public-api which relies on rustdoc JSON means I have high stakes in the rustdoc JSON format itself. Would be great if I could be pinged when the format is about to change.

I hope this is OK. Big thanks in advance.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2022
@Mark-Simulacrum
Copy link
Member

r? rustdoc

@GuillaumeGomez
Copy link
Member

No problem. It's always nice to have more eyes!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 31, 2022

📌 Commit 6f194d7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#99186 (Use LocalDefId for closures more)
 - rust-lang#99741 (Use `impl`'s generics when suggesting fix on bad `impl Copy`)
 - rust-lang#99844 (Introduce an ArchiveBuilderBuilder)
 - rust-lang#99921 (triagebot.yml: CC Enselic when rustdoc-json-types changes)
 - rust-lang#99974 (Suggest removing a semicolon and boxing the expressions for if-else)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8b2637f into rust-lang:master Jul 31, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 31, 2022
@Enselic Enselic deleted the cc-enselic branch August 19, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants