Update for merge of CrateDisambiguator into StableCrateId #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
commented
May 30, 2021
Comment on lines
+128
to
+129
| like the package version, source, and the target kind (a lib and test can have | ||
| the same crate name, so they need to be disambiguated). |
There was a problem hiding this comment.
If the bin crate type is used, this is included in the hash and as such a lib and bin never have the same hash. The comment about this describes this exact use case. This was true even before CrateDisambiguator was merged into StableCrateId.
|
The relevant PR upstream might get reverted (rust-lang/rust#85804 (comment)) so we may want to hold off on this for a bit. |
LeSeulArtichaut
added
the
S-blocked
|
FYI: revert revert PR (rust-lang/rust#86143) is on review. |
JohnTitor
added
S-waiting-on-review
|
The above PR has been merged 🎉 @bjorn3 IIUC this PR doesn't need an additional change and we can merge it now, right? |
|
Correct. |
jyn514
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#85804