Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issues for many TODOs #1163

Merged
merged 3 commits into from
Jul 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ast-validation.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
AST validation is the process of checking various correctness properties about
the AST after macro expansion.

**TODO**: write this chapter.
**TODO**: write this chapter. [#656](https://github.com/rust-lang/rustc-dev-guide/issues/656)
5 changes: 3 additions & 2 deletions src/backend/inline-asm.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Inline Assembly

**TODO: You can find more info in
https://github.com/rust-lang/rust/pull/69171#issue-375572066**
**TODO**: You can find more info
[here](https://github.com/rust-lang/rust/pull/69171#issue-375572066)
[#1162](https://github.com/rust-lang/rustc-dev-guide/issues/1162)
4 changes: 3 additions & 1 deletion src/crates-io.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ reasons:
- The dependency may have transitive dependencies that have one of the above
problems.

TODO: what is the vetting process?
As of <!-- date: 2021-07 --> July 2021, there is no official policy for vetting
new dependencies to the compiler. Generally, new dependencies are not added
to the compiler unless there is a good reason to do so.

## Permitted dependencies

Expand Down
3 changes: 1 addition & 2 deletions src/debugging-support-in-rustc.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,7 @@ Clang always embeds an MD5 checksum, though this does not appear in documentatio
* New demangler in `libiberty` (gcc source tree).
* New demangler in LLVM or LLDB.

**TODO**: Check the location of the demangler source.
[Question on Github](https://github.com/rust-lang/rustc-dev-guide/pull/316#discussion_r283062536).
**TODO**: Check the location of the demangler source. [#1157](https://github.com/rust-lang/rustc-dev-guide/issues/1157)

#### Reuse Rust compiler for expressions

Expand Down
2 changes: 1 addition & 1 deletion src/feature-gate-ck.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Feature Gate Checking

**TODO**: this chapter
**TODO**: this chapter [#1158](https://github.com/rust-lang/rustc-dev-guide/issues/1158)
2 changes: 1 addition & 1 deletion src/hir-debugging.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ The `-Z unpretty=hir-tree` flag will dump out the HIR.
If you are trying to correlate `NodeId`s or `DefId`s with source code, the
`--pretty expanded,identified` flag may be useful.

TODO: anything else?
TODO: anything else? [#1159](https://github.com/rust-lang/rustc-dev-guide/issues/1159)
2 changes: 1 addition & 1 deletion src/identifiers.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ See the [HIR chapter][hir-map] for more detailed information.
- [`Promoted`] identifies a promoted constant within another item (related to
const evaluation). Note: it is unique only locally within the item, so it
should be associated with a `DefId`.
[`GlobalId`] will give you a more specific identifier (TODO).
[`GlobalId`] will give you a more specific identifier.

- [`GlobalId`] identifies a global variable: a `const`, a `static`, a `const fn`
where all arguments are [zero-sized types], or a promoted constant.
Expand Down
4 changes: 2 additions & 2 deletions src/macro-expansion.md
Original file line number Diff line number Diff line change
Expand Up @@ -608,10 +608,10 @@ Because the Rust ABI is unstable, we use the C ABI for this conversion.
[pm]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_expand/proc_macro/index.html
[pms]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_expand/proc_macro_server/index.html

TODO: more here.
TODO: more here. [#1160](https://github.com/rust-lang/rustc-dev-guide/issues/1160)

### Custom Derive

Custom derives are a special type of proc macro.

TODO: more?
TODO: more? [#1160](https://github.com/rust-lang/rustc-dev-guide/issues/1160)
2 changes: 1 addition & 1 deletion src/name-resolution.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ To tell the difference between speculative loads and loads initiated by the
user, resolve passes around a `record_used` parameter, which is `false` when
the load is speculative.

## TODO:
## TODO: [#16](https://github.com/rust-lang/rustc-dev-guide/issues/16)

This is a result of the first pass of learning the code. It is definitely
incomplete and not detailed enough. It also might be inaccurate in places.
Expand Down
2 changes: 1 addition & 1 deletion src/type-checking.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ For more details, see the [`collect`][collect] module.
[queries]: ./query.md
[collect]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_typeck/collect/

**TODO**: actually talk about type checking...
**TODO**: actually talk about type checking... [#1161](https://github.com/rust-lang/rustc-dev-guide/issues/1161)