Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to quickly edit a page directly on github #1180

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Aug 5, 2021

No description provided.

@jyn514
Copy link
Member

jyn514 commented Aug 15, 2021

Hmm, how does this work? I built the book locally but I don't see an "edit" button. The github link in the top right just goes to the repository root, which is already enabled before this PR.
image

@jyn514
Copy link
Member

jyn514 commented Aug 15, 2021

Looks like this was added in rust-lang/mdBook#1506, and the first release since then was 0.4.8: https://lib.rs/crates/mdbook/versions. Can you also update MDBOOK_VERSION in .github/workflows/ci.yml so this will work properly on github pages?

@jyn514 jyn514 added the waiting-on-author This PR is waiting for additional action by the OP label Aug 15, 2021
v0.4.7 didn't have the feature to allow this

See rust-lang#1180 (comment)
@jyn514 jyn514 merged commit 74b138e into rust-lang:master Aug 16, 2021
@tshepang tshepang deleted the edit-convenience branch August 16, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author This PR is waiting for additional action by the OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants