Add a paragraph on installing ninja-build in order to build LLVM
#1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
ninja is already listed in the prerequisites. And there it lists either gnu make or ninja. Links to install instructions should probably go there. |
|
Hmm. It says "ninja, or GNU make 3.81 or later", and in rust-lang/rust#89091 I had GNU make, which was not sufficient by default. (Also, there are several things called ninja.) |
|
@daira GNU make would have worked if you had ninja = false in config.toml. We shouldn't remove those docs. |
camelid
added
the
S-waiting-on-author
|
I'm going to close this for now - I think improving errors from x.py is better than making the guide even longer, and it's not clear to me that this would be easy to find if you're building for the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs rust-lang/rust#89091
Signed-off-by: Daira Hopwood daira@jacaranda.org