Clarify that r? works in comments. #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwanders
force-pushed
the
clarify-r-questionmark-works-in-comments
branch
from
4b732c2
to
03cc4ef
Compare
camelid
reviewed
Jan 21, 2022
camelid
added
the
S-waiting-on-author
|
Thanks! I left one comment, otherwise this looks good. |
iwanders
force-pushed
the
clarify-r-questionmark-works-in-comments
branch
from
03cc4ef
to
68785e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the docs here I thought
r?only applied to the original PR description. @nagisa pointed out out that it should work in comments, so adding that information to the guide seems relevant as it currently only talks about the initial description.