lower-case "Compiler" in headings, for consistency (and looks) #1605

tshepang · 2023-02-17T01:41:15Z

No description provided.

camelid

Hmm, if we're going to do this, I think we should also lowercase the other titles (e.g. "Suggested Workflows" or "Sanitizers").

But I actually wonder if we should just capitalize all the titles since title case is standard for chapter names?

tshepang · 2023-02-17T06:40:33Z

I wanted to keep it small and just start with being consistent with where "compiler" is found. I also prefer non-title case (just aesthetics), and I think there was a PR that moved headings away from title case.

camelid

Thanks! One small change and then this is good to go.

src/building/bootstrapping.md

See rust-lang#1605 (comment)

Update books ## rust-lang/book 1 commits in d94e03a18a2590ed3f1c67b859cb11528d2a2d5c..21a2ed14f4480dab62438dcc1130291bebc65379 2023-02-13 19:45:29 UTC to 2023-02-13 19:45:29 UTC - Removed "," typo on ch03-01 line 85 (rust-lang/book#3537) ## rust-lang/reference 1 commits in e5adb99c04817b7fbe08f4ffce5b36702667345f..a9afb04b47a84a6753e4dc657348c324c876102c 2023-02-14 14:57:15 UTC to 2023-02-14 14:57:15 UTC - Document the `efiapi` ABI (rust-lang/reference#1309) ## rust-lang/rust-by-example 1 commits in efe23c4fe12e06351b8dc8c3d18312c761455109..af0998b7473839ca75563ba3d3e7fd0160bef235 2023-02-15 18:17:20 UTC to 2023-02-15 18:17:20 UTC - Typographical mistake in tuples.md (rust-lang/rust-by-example#1685) ## rust-lang/rustc-dev-guide 30 commits in 41a96ab971cb45e2a184df20619ad1829765c990..b06dab84083390e0ee1e998f466545a8a1a76a9f 2023-02-26 22:30:52 UTC to 2023-02-14 05:16:01 UTC - Fixed typing errors (rust-lang/rustc-dev-guide#1622) - this remains true (rust-lang/rustc-dev-guide#1620) - diagnostics: small fixes/improvements (rust-lang/rustc-dev-guide#1618) - typo (rust-lang/rustc-dev-guide#1616) - typo (rust-lang/rustc-dev-guide#1617) - keep "grey area" lint summary green (rust-lang/rustc-dev-guide#1619) - new solver: write canonicalization chapter (rust-lang/rustc-dev-guide#1595) - bootstrap now creates a usable toolchain when building stage0 std (rust-lang/rustc-dev-guide#1615) - llvm 13 is now not supported (rust-lang/rustc-dev-guide#1612) - enable AND search (rust-lang/rustc-dev-guide#1607) - Vetting deps datecheck (rust-lang/rustc-dev-guide#1614) - mention Dev desktops, to help with LLVM builds (rust-lang/rustc-dev-guide#1613) - fix and clarify llvm bugfix policy (rust-lang/rustc-dev-guide#1611) - lower-case "Compiler" in headings, for consistency (and looks) (rust-lang/rustc-dev-guide#1605) - Explain what the rest of the backend agnostic page is about (rust-lang/rustc-dev-guide#1609) - Bump dependencies to fix CI (rust-lang/rustc-dev-guide#1610) - rustc_codegen_ssa feels permanent enough not to need date-check (rust-lang/rustc-dev-guide#1606) - make use of the `host` symlink in the build directory, to ease things (rust-lang/rustc-dev-guide#1608) - have checkboxes only point to date-check lines in files (rust-lang/rustc-dev-guide#1603) - remove stray text (rust-lang/rustc-dev-guide#1604) - Typo (rust-lang/rustc-dev-guide#1601) - Typo (rust-lang/rustc-dev-guide#1602) - Add link to vscode settings in Rust repo (rust-lang/rustc-dev-guide#1591) - avoid code duplication by including files in docs (rust-lang/rustc-dev-guide#1598) - howto run the examples (rust-lang/rustc-dev-guide#1593) - Add sample CodeLLDB launch.json (rust-lang/rustc-dev-guide#1482) - typo (rust-lang/rustc-dev-guide#1600) - use actual names (rust-lang/rustc-dev-guide#1594) - Fix a typo (rust-lang/rustc-dev-guide#1597) - Add Neovim configuration information (rust-lang/rustc-dev-guide#1545)

lower-case "Compiler" in headings, for consistency (and looks)

8a38480

camelid reviewed Feb 17, 2023

View reviewed changes

camelid added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Feb 17, 2023

camelid approved these changes Feb 17, 2023

View reviewed changes

src/building/bootstrapping.md Show resolved Hide resolved

impl review suggestion

bcdc217

See rust-lang#1605 (comment)

tshepang merged commit 6f536e4 into rust-lang:master Feb 18, 2023

tshepang deleted the lower-case branch February 18, 2023 03:04

rustbot mentioned this pull request Feb 27, 2023

Update books rust-lang/rust#108536

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lower-case "Compiler" in headings, for consistency (and looks) #1605

lower-case "Compiler" in headings, for consistency (and looks) #1605

tshepang commented Feb 17, 2023

camelid left a comment

tshepang commented Feb 17, 2023

camelid left a comment

lower-case "Compiler" in headings, for consistency (and looks) #1605

lower-case "Compiler" in headings, for consistency (and looks) #1605

Conversation

tshepang commented Feb 17, 2023

camelid left a comment

Choose a reason for hiding this comment

tshepang commented Feb 17, 2023

camelid left a comment

Choose a reason for hiding this comment