Add documentation on Apple notification group #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
requested changes
May 5, 2024
| @@ -57,6 +58,7 @@ cargo run add-person $your_user_name | |||
|
|
|||
| Example PRs: | |||
|
|
|||
| * [Example of adding yourself to the Apple group.](https://github.com/rust-lang/team/pull/1434) | |||
There was a problem hiding this comment.
Please add a note here that the correct file to change is now teams/apple.toml, not teams/macos.toml seen in the link.
We should swap this out with a better example once one exists of someone adding themself to apple.toml.
There was a problem hiding this comment.
I'ved added a comment here: rust-lang/team#1434 (comment)
|
I'll merge this to unblock rust-lang/rust#124146, as "rustbot ping apple" is currently broken otherwise. Thanks! |
dtolnay
approved these changes
May 5, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
Update books ## rust-lang/book 3 commits in d207d894cc5e1d496ab99beeacd1a420e5d4d238..bebcf527e67755a989a1739b7cfaa8f0e6b30040 2024-04-30 02:06:57 UTC to 2024-04-25 21:04:25 UTC - [ch10-03] Fix wording change about mandatory type annotation (rust-lang/book#3904) - Introduce handling for accessible/semantic note rendering in HTML (rust-lang/book#3907) - Backport changes from print for ch7 (rust-lang/book#3901) ## rust-embedded/book 1 commits in aa7d4b0b4653ddb47cb1de2036d090ec2ba9dab1..17842ebb050f62e40a4618edeb8e8ee86e758707 2024-05-01 13:23:40 UTC to 2024-05-01 13:23:40 UTC - Update embedded rust debugging section of tooling.md (rust-embedded/book#369) ## rust-lang/reference 1 commits in 5854fcc286557ad3ab34d325073d11d8118096b6..51817951d0d213a0011f82b62aae02c3b3f2472e 2024-04-27 17:54:45 UTC to 2024-04-27 17:54:45 UTC - Add docs for `#[collapse_debuginfo]` attribute (rust-lang/reference#1468) ## rust-lang/rust-by-example 3 commits in 60d34b5fd33db1346f9aabfc0c9d0bda6c8e42be..229ad13b64d919b12e548d560f06d88963b25cd3 2024-05-06 00:15:45 UTC to 2024-04-24 18:29:38 UTC - Missing import (rust-lang/rust-by-example#1841) - Added missing word (rust-lang/rust-by-example#1838) - Raw string literal can contain up to 255 #s according to Rust Reference (rust-lang/rust-by-example#1839) ## rust-lang/rustc-dev-guide 5 commits in 07425fed36b00e60341c5e29e28d37d40cbd4451..2d1947ff34d50ca46dfe242ad75531a4c429bb52 2024-05-06 06:48:21 UTC to 2024-04-28 18:31:21 UTC - Add documentation for check-cfg by-default in UI tests (rust-lang/rustc-dev-guide#1966) - Add documentation on Apple notification group (rust-lang/rustc-dev-guide#1964) - Update CI documentation to avoid mentioning `expand-yaml-anchors` (rust-lang/rustc-dev-guide#1971) - Rename `-Z verbose` to `-Z verbose-internals` (rust-lang/rustc-dev-guide#1968) - typo traige->triage (rust-lang/rustc-dev-guide#1967)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
Update books ## rust-lang/book 3 commits in d207d894cc5e1d496ab99beeacd1a420e5d4d238..bebcf527e67755a989a1739b7cfaa8f0e6b30040 2024-04-30 02:06:57 UTC to 2024-04-25 21:04:25 UTC - [ch10-03] Fix wording change about mandatory type annotation (rust-lang/book#3904) - Introduce handling for accessible/semantic note rendering in HTML (rust-lang/book#3907) - Backport changes from print for ch7 (rust-lang/book#3901) ## rust-embedded/book 1 commits in aa7d4b0b4653ddb47cb1de2036d090ec2ba9dab1..17842ebb050f62e40a4618edeb8e8ee86e758707 2024-05-01 13:23:40 UTC to 2024-05-01 13:23:40 UTC - Update embedded rust debugging section of tooling.md (rust-embedded/book#369) ## rust-lang/reference 1 commits in 5854fcc286557ad3ab34d325073d11d8118096b6..51817951d0d213a0011f82b62aae02c3b3f2472e 2024-04-27 17:54:45 UTC to 2024-04-27 17:54:45 UTC - Add docs for `#[collapse_debuginfo]` attribute (rust-lang/reference#1468) ## rust-lang/rust-by-example 3 commits in 60d34b5fd33db1346f9aabfc0c9d0bda6c8e42be..229ad13b64d919b12e548d560f06d88963b25cd3 2024-05-06 00:15:45 UTC to 2024-04-24 18:29:38 UTC - Missing import (rust-lang/rust-by-example#1841) - Added missing word (rust-lang/rust-by-example#1838) - Raw string literal can contain up to 255 #s according to Rust Reference (rust-lang/rust-by-example#1839) ## rust-lang/rustc-dev-guide 5 commits in 07425fed36b00e60341c5e29e28d37d40cbd4451..2d1947ff34d50ca46dfe242ad75531a4c429bb52 2024-05-06 06:48:21 UTC to 2024-04-28 18:31:21 UTC - Add documentation for check-cfg by-default in UI tests (rust-lang/rustc-dev-guide#1966) - Add documentation on Apple notification group (rust-lang/rustc-dev-guide#1964) - Update CI documentation to avoid mentioning `expand-yaml-anchors` (rust-lang/rustc-dev-guide#1971) - Rename `-Z verbose` to `-Z verbose-internals` (rust-lang/rustc-dev-guide#1968) - typo traige->triage (rust-lang/rustc-dev-guide#1967)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup merge of rust-lang#124815 - rustbot:docs-update, r=ehuss Update books ## rust-lang/book 3 commits in d207d894cc5e1d496ab99beeacd1a420e5d4d238..bebcf527e67755a989a1739b7cfaa8f0e6b30040 2024-04-30 02:06:57 UTC to 2024-04-25 21:04:25 UTC - [ch10-03] Fix wording change about mandatory type annotation (rust-lang/book#3904) - Introduce handling for accessible/semantic note rendering in HTML (rust-lang/book#3907) - Backport changes from print for ch7 (rust-lang/book#3901) ## rust-embedded/book 1 commits in aa7d4b0b4653ddb47cb1de2036d090ec2ba9dab1..17842ebb050f62e40a4618edeb8e8ee86e758707 2024-05-01 13:23:40 UTC to 2024-05-01 13:23:40 UTC - Update embedded rust debugging section of tooling.md (rust-embedded/book#369) ## rust-lang/reference 1 commits in 5854fcc286557ad3ab34d325073d11d8118096b6..51817951d0d213a0011f82b62aae02c3b3f2472e 2024-04-27 17:54:45 UTC to 2024-04-27 17:54:45 UTC - Add docs for `#[collapse_debuginfo]` attribute (rust-lang/reference#1468) ## rust-lang/rust-by-example 3 commits in 60d34b5fd33db1346f9aabfc0c9d0bda6c8e42be..229ad13b64d919b12e548d560f06d88963b25cd3 2024-05-06 00:15:45 UTC to 2024-04-24 18:29:38 UTC - Missing import (rust-lang/rust-by-example#1841) - Added missing word (rust-lang/rust-by-example#1838) - Raw string literal can contain up to 255 #s according to Rust Reference (rust-lang/rust-by-example#1839) ## rust-lang/rustc-dev-guide 5 commits in 07425fed36b00e60341c5e29e28d37d40cbd4451..2d1947ff34d50ca46dfe242ad75531a4c429bb52 2024-05-06 06:48:21 UTC to 2024-04-28 18:31:21 UTC - Add documentation for check-cfg by-default in UI tests (rust-lang/rustc-dev-guide#1966) - Add documentation on Apple notification group (rust-lang/rustc-dev-guide#1964) - Update CI documentation to avoid mentioning `expand-yaml-anchors` (rust-lang/rustc-dev-guide#1971) - Rename `-Z verbose` to `-Z verbose-internals` (rust-lang/rustc-dev-guide#1968) - typo traige->triage (rust-lang/rustc-dev-guide#1967)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 11, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
May 18, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
Triagebot: Rename `macos` ping group to `apple` Expand the scope of the macOS ping group to all Apple targets. Blocked on rust-lang/team#1436 (rename in `team` repo) Blocked on rust-lang/rustc-dev-guide#1964 (referenced documentation link) `@rustbot` label O-macos O-ios O-tvos O-watchos O-visionos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed today on Zulip that it would be nice with some documentation on this ping group.
Additionally, I've tried to document a few of the common challenges that we face on Apple platforms.
Blocked on rust-lang/team#1436.