Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the "Source Code Representation" chapters #2142

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Nov 21, 2024

This ticks off a number of boxes from #2141, specifically it:

  • Creates a new chapter Supporting Infrastructure and moves a number of unrelated chapters out of the source code repr chapter
  • Removes the chapter about IR IDs moving its information into the respective IR chapters
  • Removes a number of type definitions from the inline asm chapter, instead opting to reference the rustc

The only remaining follow ups would be to flesh out the hir chapter some more, and talk about async stuff somewhere. It might be worth moving those to their own issues though

cc @jieyouxu

@jieyouxu jieyouxu added C-cleanup Category: cleanups WG-rustc-dev-guide Working group: rustc-dev-guide labels Nov 21, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very nice cleanup 👍

@jieyouxu
Copy link
Member

flesh out the hir chapter some more, and talk about async stuff somewhere. It might be worth moving those to their own issues though

I'll split the issues.

@jieyouxu jieyouxu merged commit 5f5e0b5 into rust-lang:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: cleanups WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants