Update for TyCtxt<'a, 'gcx, 'tcx> -> TyCtxt<'tcx>. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoxc
reviewed
Jun 14, 2019
| @@ -25,7 +25,6 @@ early-bound lifetime | a lifetime region that is substituted at its definiti | |||
| empty type | see "uninhabited type". | |||
| Fat pointer | a two word value carrying the address of some value, along with some further information necessary to put the value to use. Rust includes two kinds of "fat pointers": references to slices, and trait objects. A reference to a slice carries the starting address of the slice and its length. A trait object carries a value's address and a pointer to the trait's implementation appropriate to that value. "Fat pointers" are also known as "wide pointers", and "double pointers". | |||
| free variable | a "free variable" is one that is not bound within an expression or term; see [the background chapter for more](./background.html#free-vs-bound) | |||
| 'gcx | the lifetime of the global arena ([see more](../ty.html)) | |||
There was a problem hiding this comment.
This description should be moved to 'tcx.
There was a problem hiding this comment.
Suggested change
| 'gcx | the lifetime of the global arena ([see more](../ty.html)) | |
| 'tcx | the lifetime of the allocation arena ([see more](../ty.html)) |
Zoxc
reviewed
Jun 14, 2019
| @@ -141,8 +141,7 @@ to the compiler. | |||
| - `cx` tends to be short for "context" and is often used as a suffix. For | |||
| example, `tcx` is a common name for the [Typing Context][tcx]. | |||
|
|
|||
| - [`'tcx` and `'gcx`][tcx] are used as the lifetime names for the Typing | |||
| Context. | |||
| - [`'tcx`][tcx] is used as the lifetim names for the Typing Context. | |||
There was a problem hiding this comment.
Suggested change
| - [`'tcx`][tcx] is used as the lifetim names for the Typing Context. | |
| - [`'tcx`][tcx] is used as the lifetime names for the Typing Context. |
Merged
|
@mark-i-m The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#61722 and rust-lang/rust#61817 for some backstory.
cc @mark-i-m @rust-lang/compiler