Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section: Source file checksums in debug info #623

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Mar 19, 2020

Implementation PR in Rust: rust-lang/rust#69718

@arlosi arlosi force-pushed the src-file-checksum branch from c5dd2a4 to 0a5c8e1 Compare March 19, 2020 19:25
@arlosi
Copy link
Contributor Author

arlosi commented Mar 19, 2020

r? @eddyb

@arlosi arlosi closed this Mar 19, 2020
@arlosi arlosi reopened this Mar 19, 2020
@eddyb
Copy link
Member

eddyb commented Mar 19, 2020

(this repo doesn't have any bots AFAIK)

mark-i-m
mark-i-m previously approved these changes Mar 19, 2020
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) this looks good to me, but I will leave the decision to @eddyb

@JohnTitor
Copy link
Member

I think this should be blocked until that PR is merged?

@JohnTitor JohnTitor added the S-blocked Status: this PR is blocked waiting for something label Mar 19, 2020
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thoughts

src/debugging-support-in-rustc.md Outdated Show resolved Hide resolved
src/debugging-support-in-rustc.md Show resolved Hide resolved
nikomatsakis
nikomatsakis previously approved these changes Mar 24, 2020
@arlosi arlosi force-pushed the src-file-checksum branch from d9c3438 to ed9e1cb Compare March 24, 2020 22:34
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 4, 2020
Add hash of source files in debug info

LLVM supports placing the hash of source files inside the debug info.
This information can be used by a debugger to verify that the source code matches
the executable.

This change adds support for both hash algorithms supported by LLVM, MD5 and SHA1, controlled by a target option.

* DWARF only supports MD5
* LLVM IR supports MD5 and SHA1 (and SHA256 in LLVM 11).
* CodeView (.PDB) supports MD5, SHA1, and SHA256.

Fixes rust-lang#68980.

Tracking issue: rust-lang#70401

rustc dev guide PR with further details: rust-lang/rustc-dev-guide#623
@mark-i-m mark-i-m removed the S-blocked Status: this PR is blocked waiting for something label Apr 4, 2020
@mark-i-m
Copy link
Member

mark-i-m commented Apr 4, 2020

rust-lang/rust#69718 has merged

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit b315ce5 into rust-lang:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants