Fix misguided suggestions in config.toml #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
S-waiting-on-review
tshepang
approved these changes
Aug 31, 2020
Looks like this needs the changes from #838 before CI will pass. |
- `verbose-tests` is for debugging the test harness, not the tests themselves. See also rust-lang/rust#76141 - `codegen-units` defaults to `256` whenever `incremental = true`. So there's no need to explicitly set it to `0` if we already recommend incremental. See also rust-lang#795 (comment).
jyn514
force-pushed
the
config-toml-redux
branch
from
13fe014
to
f07f8fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verbose-testsis for debugging the test harness, not the teststhemselves. See also Address review comments about config.toml from rustc-dev-guide PR rust#76141
codegen-unitsdefaults to256wheneverincremental = true. Sothere's no need to explicitly set it to
0if we already recommendincremental. See also Resync config.toml and suggest better settings #795 (comment).
r? @eddyb