Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sort failure due to NaN comparison #1175

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Avoid sort failure due to NaN comparison #1175

merged 1 commit into from
Feb 18, 2022

Conversation

Mark-Simulacrum
Copy link
Member

Noticed while looking at some bootstrap results that were incorrectly sorted -- this should ensure we always have a good sort order.

(Fixing the NaN presence is a separate problem -- I believe caused by division by zero, but not sure yet).

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Feb 17, 2022
Merged
nnethercote
nnethercote approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confused me briefly until I realized I was reading JS code rather than Rust code :)

@Mark-Simulacrum Mark-Simulacrum merged commit 17f3168 into rust-lang:master Feb 18, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the fix-bootstrap-sort branch February 18, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote approved these changes

@rylev rylev Awaiting requested review from rylev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mark-Simulacrum @nnethercote