Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitmaps-3.1.0 #1314

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Add bitmaps-3.1.0 #1314

merged 4 commits into from
Apr 28, 2022

Conversation

nnethercote
Copy link
Contributor

The final new benchmark I intend to add. I think it's a good choice because it stresses trait handling in very interesting ways, and in ways that are quite similar to nalgebra, which is another interesting case. However, bitmaps is much smaller than nalgebra, so it doesn't eat into our CI budget nearly as much.

End to end compile times:

- check: 1.35s
- debug: 1.35s
- opt: 1.50s

Final crate compile times vs helloworld:

Benchmark Profile Scenario % Change Significance Factor? Test Test
bitmaps-3.1.0 check full 0.00% - 0.963 0.963
bitmaps-3.1.0 debug full 0.00% - 0.957 0.957
bitmaps-3.1.0 opt full 0.00% - 1.078 1.078
helloworld check full 0.00% - 0.23 0.23
helloworld debug full 0.00% - 0.24 0.24
helloworld opt full 0.00% - 0.218 0.218

@nnethercote nnethercote requested a review from lqd April 28, 2022 06:33
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indeed a great find. 40% of the compilation is in specialization_graph_of and evaluate_obligation, which is close to nalgebra as you said (although in different proportions) but 20x faster to build.

@nnethercote nnethercote merged commit 8f35244 into rust-lang:master Apr 28, 2022
@nnethercote nnethercote deleted the add-bitmaps branch April 28, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants