Add a chart showing individual compilation parts to benchmark detail #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
fraction-chart
branch
from
714989f to
b5fff9c
Compare
Kobzol
force-pushed
the
fraction-chart
branch
3 times, most recently
from
4aa168c to
138dad3
Compare
Kobzol
force-pushed
the
fraction-chart
branch
from
138dad3 to
bf6f4c6
Compare
|
I separated the endpoints for the graphs and for the compilation sections, so that the (slow) section loading doesn't slow down the loading of the graphs. |
A separate endpoint was created, because loading the sections requires loading self-profile data, which can be quite slow. Making it a separate endpoint won't block loading of the graphs, which are loaded quite fast.
Kobzol
force-pushed
the
fraction-chart
branch
from
bf6f4c6 to
2de22b2
Compare
Mark-Simulacrum
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we have a better idea of how much time is spent in frontend/backend/linking, and also how are these fractions changed by individual PRs. The data is loaded from self-profile files and it's calculated based on time spent in individual self-profile queries. There is currently a super rough heuristic that tries to estimate into which part does a query belong.