Add benchmark with many associated items #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me but looks like this needs a rebase, sorry for missing it initially |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#68957 demonstrated an increase in compile times that was quadratic in the number of associated items. rust-lang/rust#68837 sped these cases up a lot, and rust-lang/rust#69072 hopes to speed them up even more by making associated item name lookup O(log n).
This benchmark has been reduced in size from the original example to run in ~2 seconds locally. I was hoping to find a more real-world example that demonstrated the pathological behavior–embedded HAL crates were mentioned–but gave up.