Port up to LLVM commit 55c2211a233e11179048cf58778f40e5a62f444a #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no, we should've gotten in touch, I didn't even see this PR because I don't have I had a lot of this already done in https://github.com/rust-lang/rustc_apfloat/tree/advance-port-b0abd48-jun-2023, and it's very possible that conflicts with what you've done here :( We didn't end up landing it because Not sure how to proceed here, might be best if you can contact me ( |
eduardosm
changed the title
Skips through the followings commits that do not affect the Rust port: * 38818b60c58c76ba89b990978cdfd2d7b6799260: only affects C++/LLVM specific details * 85395af27241ab9c8d5763b8afcaa07f1bab26d5: reverted by next commit * e60b91df1357e6a5f66840581f4d5f57e258c0b4: reverts previous commit
Bumps LLVM commit to 4dc08de9d2f680309cdd639169d3b8802c76ae9a, where the equivalent was done in the C++ version.
Returns the number of bits needed to represent the largest integer that a floating point type can hold. Bumps LLVM commit to 038f7debfda01471ce0d4eb1fed20da61e5c8b32, where this was added upstream.
Upstream LLVM commit: 6109e70c72fc5171d25c4467fc3cfe6eb2029f50 Adds Float8E5M2FNUZ and Float8E4M3FNUZ formats, where NaN is represented as negative zero TODO: tests
Also includes small improvements to `ieee.rs`
Upstream LLVM commit: 83ba349ae0a853e0c2cd8e8aadc88993e9fb9a19 Previous commit, 36606cf07080a44a1a9157f80112f9512bd6a3bf, has been skipped because it does not affect the Rust port.
Skips through the followings commits that do not affect the Rust port: * f8f3db27565cae8e07c2487f9714a32840c6d548: irrelevant because the Rust port does not have APInt equivalent * 71f1ea2c15bbc5b604e20d71191a16d57d106dc0: we already have a similar `Float::category`
Upstream LLVM commit: 2f086f265bf97fe6543fb199f4ef874ca3522479 TODO: tests
Upstream LLVM commit: 3d11652bbee4cd6782c474e28cb2ab58fc93f245 Note that most changes of the LLVM commit do not apply to the Rust port
Upstream LLVM commit: 69668590592fcca2c2b22ba2257be57f0319fc9c The following commits are skipped: * 9395cf063a013003704118deccf7633533170a5b: reverted by next commit * 69668590592fcca2c2b22ba2257be57f0319fc9c: reverts previous commit
Skips through the followings commits that do not affect the Rust port: * 8e58b79f67a9f921733b105a874c0d4f69dd50da: fixes typos not present in the Rust port * 687bd77e2c26487cba727aacfa7067dd01286be0: C++ specific changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most significant change is the addition of new floating point types that represent NaNs as negative zeros.