Add licensing information #2
Conversation
There was a problem hiding this comment.
This all seems really good overall, thanks again for all the effort analyzing all that upstream history!
I'm only noting down some tiny details (i.e. outside of the main licensing explanation itself) I'm unsure on - in the spirit of "measure twice and cut commit once".
| Subsequent work on this crate has advanced the state of the port from the original commit. | ||
| Reviewing the set of upstream LLVM changes after revision `f3598e8fca83ccfb11f58ec7957c229e349765e3` and before the relicensing on 2019-01-19 reveals 41 changes all of which LLVM has relicensing agreements with their authors. | ||
| As such, these changes and all changes made to LLVM after the relicensing data are available under the Apache 2 with LLVM Exception license. |
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't feel particularly strong with regards to that point. We're very confident that everything done here is covered by Apache-2.0 WITH LLVM-exception and has been done correctly. The timing of this PR going in relative to #1 doesn't change that.
Given that the work has already occurred, it just hasn't been merged into this repo yet, I think what's written is still correct and we can merge the PRs in any order.
Co-authored-by: Eduard-Mihai Burtescu <edy.burt@gmail.com>
cc @eddyb @pnkfelix