This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Ignore duplicate replacements #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2018
killercup
approved these changes
Jul 16, 2018
Currently the compiler suffers from bugs like rust-lang/rust#51211 where it will emit duplicate suggestions for code that originates in a macro. This commit allows rustfix to accept and process these suggestions by ignoring exact duplicates of replacements. While not a great solution long term it should hopefully be a non-harmful band-aid until rustc is fixed!
3 tasks
This was referenced Jul 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the compiler suffers from bugs like rust-lang/rust#51211 where it will
emit duplicate suggestions for code that originates in a macro. This commit
allows rustfix to accept and process these suggestions by ignoring exact
duplicates of replacements. While not a great solution long term it should
hopefully be a non-harmful band-aid until rustc is fixed!