This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Fix panic computing indentation. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am tempted to just completely remove the |
Manishearth
approved these changes
Aug 31, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where rustfix would panic on input where the
highlight_startappears within whitespace characters. The issue is that the code computing the indent was comparing the indent (which is 0-based) to thehighlight_start(which is 1-based). All the following code expects 0-based offsets.In this particular example, the
let lead = text_slice[indent..start]would panic because indent is 1 whereasstartis 0.