Skip to content

Commit

Permalink
reviewer comments and rebase fallout
Browse files Browse the repository at this point in the history
  • Loading branch information
nrc committed Mar 16, 2018
1 parent d9942d3 commit 627f688
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 14 deletions.
27 changes: 14 additions & 13 deletions Configurations.md
Original file line number Diff line number Diff line change
Expand Up @@ -1297,27 +1297,28 @@ Reorder import statements in group

**Note:** This option takes effect only when [`reorder_imports`](#reorder_imports) is set to `true`.

#### `false` (default):
#### `true` (default):

```rust
use std::io;
use std::mem;

use dolor;
use ipsum;
use lorem;
use sit;
use std::io;
use std::mem;
```

#### `true`:
#### `false`:

```rust
use std::io;
use std::mem;

```rust
use dolor;
use ipsum;
use lorem;
use sit;
use std::io;
use std::mem;
```

See also [`reorder_imports`](#reorder_imports).
Expand Down Expand Up @@ -1359,7 +1360,11 @@ Reorder `extern crate` statements in group
- **Possible values**: `true`, `false`
- **Stable**: No

#### `true` (default):
#### `false` (default):

This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered.

#### `true`:

**Note:** This only takes effect when [`reorder_extern_crates`](#reorder_extern_crates) is set to `true`.

Expand All @@ -1373,10 +1378,6 @@ extern crate lorem;
extern crate sit;
```

#### `false`:

This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered.

## `reorder_modules`

Reorder `mod` declarations alphabetically in group.
Expand All @@ -1385,7 +1386,7 @@ Reorder `mod` declarations alphabetically in group.
- **Possible values**: `true`, `false`
- **Stable**: No

#### `true`
#### `true` (default)

```rust
mod a;
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ use std::time::Duration;
use syntax::ast;
pub use syntax::codemap::FileName;
use syntax::codemap::{CodeMap, FilePathMapping};
use syntax::errors::{DiagnosticBuilder, Handler};
use syntax::errors::emitter::{ColorConfig, EmitterWriter};
use syntax::errors::{DiagnosticBuilder, Handler};
use syntax::parse::{self, ParseSess};

use checkstyle::{output_footer, output_header};
Expand Down

0 comments on commit 627f688

Please sign in to comment.