Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ binding reformatted strangely on rustfmt from rustc 1.41.0-beta.4 #4031

Closed
wezm opened this issue Jan 28, 2020 · 3 comments · Fixed by #4123 or #4978
Closed

@ binding reformatted strangely on rustfmt from rustc 1.41.0-beta.4 #4031

wezm opened this issue Jan 28, 2020 · 3 comments · Fixed by #4123 or #4978

Comments

@wezm
Copy link
Member

wezm commented Jan 28, 2020

The following line is formatting differently and in an undesirable way with rustfmt from rustc beta (1.41.0-beta.4):

https://github.com/yeslogic/allsorts/blob/c78fb470ca2a575570543918cfbf15422b0377b2/tests/woff2.rs#L236

The diff looks like this:

Diff in /home/travis/build/yeslogic/allsorts/tests/woff2.rs at line 233:
             .iter()
             .map(|glyph| match glyph {
                 GlyfRecord::Parsed(
-                    found @ Glyph {
+                    found
+                    @
+                    Glyph {
                         data: GlyphData::Composite { .. },
                         ..
                     },
@Follpvosten
Copy link

I still have this issue with a nested pattern on 1.57:

if let Some(
    mut
    ppart
    @
    PathPart {
        kind: PartKind::End { grid_width },
        ..
    },
) = ppart
{
    // ...
}

should I open a new bug for it?

@calebcartwright
Copy link
Member

I still have this issue with a nested pattern on 1.57:

Are you using stable? If so I don't think the fix will hit stable till 1.58, but should already be on nightly

@Follpvosten
Copy link

@calebcartwright Yes, I'm using stable, and good to know. If there is a fix that's about to be published in 1.59, that's good enough for me.

pearljt added a commit to pearljt/allsorts that referenced this issue Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants