Use scoped attributes for skip attribute #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
reviewed
May 14, 2018
| @@ -584,6 +596,33 @@ impl<'b, 'a: 'b> FmtVisitor<'a> { | |||
|
|
|||
| // Returns true if we should skip the following item. | |||
| pub fn visit_attrs(&mut self, attrs: &[ast::Attribute], style: ast::AttrStyle) -> bool { | |||
| for attr in attrs { | |||
There was a problem hiding this comment.
Checking for deprecated rustfmt_skip or invalid scoped attributes inside visit_attrs means that we cannot emit warnings for attributes on expressions (we use contains_skip for expressions).
It would be nice if we can perform this check inside contains_skip. I think we can do so by adding RefCell<FormatReport> field to RewriteContext and pass &RewriteContext to contains_skip.
There was a problem hiding this comment.
I was hesitant to do this because there is no guarantee that contains_skip will be called only once per attribute and so we potentially end up having to deduplicate errors. Attributes on expressions are also unstable and not widely used, so I don't think it matters too much.
topecongiro
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @topecongiro
cc #1978