New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"first" element check does nothing #3519

Merged

topecongiro merged 1 commit into rust-lang:master from oli-obk:patch-1

Apr 22, 2019

Contributor

oli-obk commented Apr 22, 2019

cc rust-lang/rust-clippy#4016

found by grepping the rustc source since I was just looking at another instance of this


          "first" element check does nothing

c60d6dd

topecongiro merged commit 31a6942 into rust-lang:master

Contributor

topecongiro commented Apr 22, 2019

Good catch, thanks!

kraai commented Apr 23, 2019

@oli-obk Is the other instance https://github.com/rust-lang/rust/blob/004c549a73122a9867de4f64ac727deb95d426a5/src/librustc_codegen_utils/symbol_names.rs#L428?

Contributor Author

oli-obk commented Apr 23, 2019

@kraai yes, I'm addressing it in rust-lang/rust#60166

oli-obk deleted the patch-1 branch

April 23, 2019 09:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet