-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute_path instead of fs::canonicalize #3590
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into topecongiro-absolute-path
This was referenced Jun 2, 2019
Bump... |
Ping @topecongiro @scampi , this has been languishing for almost a year. |
At this point it might be easiest if someone wanted to grab the commits or changes and try from a new PR, especially considering all the subsequent changes |
Closing in favor of #4131. |
rivy
added a commit
to rivy/rs.coreutils
that referenced
this pull request
May 30, 2020
- unneeded after reorg - but issue still remains; see GH:/rust-lang/rustfmt#3590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3324:
I think the comments regarding canonical paths by @rivy and @Xanewok can be revisited later once some fixes on rust itself are done (see list of open issues #1873 (comment)). I'll open an issue to track this.
Close #1873