Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute_path instead of fs::canonicalize #3590

Closed
wants to merge 8 commits into from

Conversation

scampi
Copy link
Contributor

@scampi scampi commented May 27, 2019

This is a continuation of #3324:

  • add a test for relative path to modules
  • tested the fix proposed by @topecongiro works on a windows environment.

I think the comments regarding canonical paths by @rivy and @Xanewok can be revisited later once some fixes on rust itself are done (see list of open issues #1873 (comment)). I'll open an issue to track this.

Close #1873

@rivy
Copy link

rivy commented Jan 11, 2020

Any progress on this?
Using Windows cargo fmt is broken for lots of repos because of this...

refs: #1873 , #3324, #3603, #3688

@Diggsey
Copy link

Diggsey commented Mar 9, 2020

Bump...

@rivy
Copy link

rivy commented Apr 4, 2020

Ping @topecongiro @scampi , this has been languishing for almost a year.
What can we do to push it forward?
As I said before, this is the base cause of issues in lots of repos.

@calebcartwright
Copy link
Member

At this point it might be easiest if someone wanted to grab the commits or changes and try from a new PR, especially considering all the subsequent changes

@topecongiro
Copy link
Contributor

Closing in favor of #4131.

rivy added a commit to rivy/rs.coreutils that referenced this pull request May 30, 2020
- unneeded after reorg
- but issue still remains; see GH:/rust-lang/rustfmt#3590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to format nested mod with relative path on windows
5 participants